Ignore unexpected properties when deserializing a ContentBlock#956
Merged
jeffhandley merged 3 commits intomodelcontextprotocol:mainfrom Nov 9, 2025
Conversation
jeffhandley
force-pushed
the
jeffhandley/structuredcontent-parse-failure
branch
from
2b15f2c to
019075c
Compare
Contributor
Author
|
@stephentoub / @eiriktsarpalis - After fixing the reported case, Copilot and I looked at all other While looking through this, Copilot found that All of these extra fixes are in a separate commit from the original fix, in case you think we should drop the auxiliary changes. |
stephentoub
reviewed
Nov 9, 2025
stephentoub
reviewed
Nov 9, 2025
stephentoub
approved these changes
Nov 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #955 - Skip unexpected properties when deserializing
ContentBlockMotivation and Context
This issue was encountered and reported by a colleague working with a server that returned data in an old/unexpected structure.
How Has This Been Tested?
Repro console app and a failing unit test were created. The new tests now succeed.
Types of changes
Checklist