Add an optional mimeType property to TextContent#662
Add an optional mimeType property to TextContent#662atesgoral wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
hesreallyhim
left a comment
There was a problem hiding this comment.
suggestion: it sounds like we're going to end up with three ContentTypes:
TextContent | ImageContent | AudioContent
and they're each going to have type, mimeType, and annotations? properties, which sounds to me like a good opportunity for a shared interface from which to extend
|
@hesreallyhim Ah, actually this is a small patch before we potentially rock the boat and unify types: #180 (reply in thread) |
ok, thanks for the context 👍 |
|
I'd prefer this was fixed to |
|
@evalstate can you elaborate? What does "fixing" mean in this context? Assume all |
|
Yes, my view is that TextContent should have the guarantee that it is
The potential breakage here is that Server developers think they want to send There are rare exceptions (e.g. models like StarVector) but the general case is that having a modifiable mime type on TextContent this will cause unnecessary complexity and breakages. At the moment |
|
LGTM. @atesgoral - mind resolving the schema conflicts in this PR? |
🏠 Remote-Dev: homespace
d3fc9c0 to
29a9695
Compare
🏠 Remote-Dev: homespace
|
@localden My GH notification settings suck. I missed your ping. Looking now. Update: Thank you for updating it! |
|
@evalstate @olaservo @jonathanhefner @cliffhall any concerns with this merging as-is? |
Back when this was proposed I was in favor of it. In particular, I was in favor of having just But since then, I've flipped to favoring |
Motivation and Context
Addresses #180
Where @jspahrsummers said:
How Has This Been Tested?
No. Just adding an optional property to the schema.
Breaking Changes
No.
Types of changes
Checklist
Additional context