fixing issue: Determinant function raises TypeError on simple matrix #542#543
fixing issue: Determinant function raises TypeError on simple matrix #542#543sonntagsgesicht wants to merge 7 commits intompmath:masterfrom sonntagsgesicht:master
Conversation
|
The solution looks like a bit of a hack, and it's problematic that it doesn't account for the scaling of the matrix. For example, it will return 0 if you input the identity matrix times 1e-30. It would be fine if you check any column for being exactly zero, but perhaps that isn't general enough. |
|
Yes, you are right. Had a closer look and fixed it directly inside LU_comp where pivoting failed. |
|
If you don't like the compact This checks that the expected exception is thrown somewhere within the "with"-block, and is actually the recommended notation in the pytest docs. |
|
The updated fix looks good to me. |
(Update on PR #543) Fixed TypeError in `LU_comp`, updated `determinant` docs and added `rank` function for matrices
No description provided.