Use math.isqrt in isqrt_python calculations#695
Merged
skirpichev merged 2 commits intompmath:masterfrom May 10, 2023
Merged
Conversation
skirpichev
requested changes
May 9, 2023
Collaborator
skirpichev
left a comment
skirpichev
left a comment
There was a problem hiding this comment.
So, please just use math.isqrt for isqrt, isqrt_fast, etc for python versions >= 3.12, if the BACKEND is not 'gmpy' or 'sage'.
skirpichev
approved these changes
May 10, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
isqrt_pythoncalculation is faster usingmath.isqrtwhen x is small.For speed comparisons, see the following PR
sympy/sympy#25111