Avoid using star imports in tests and documentation#698
Merged
skirpichev merged 30 commits intompmath:masterfrom May 10, 2023
Merged
Avoid using star imports in tests and documentation#698skirpichev merged 30 commits intompmath:masterfrom
skirpichev merged 30 commits intompmath:masterfrom
Conversation
skirpichev
force-pushed
the
no-star-imports
branch
from
a71b332 to
c2f604d
Compare
Contributor
|
LGTM! I proof-read the text changes and glanced over the rest. Assuming there are doctests being run, this seems fine to merge (and advantageous to do quickly to avoid conflicts) |
Collaborator
Author
Yes, they should. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.