Revert "fix ellippi to return an inf instead of raising an exception"#875
Merged
skirpichev merged 1 commit intompmath:masterfrom Oct 12, 2024
Merged
Revert "fix ellippi to return an inf instead of raising an exception"#875skirpichev merged 1 commit intompmath:masterfrom
skirpichev merged 1 commit intompmath:masterfrom
Conversation
…(thanks to John Beyers)" This reverts commit fc474e1. We don't have a concept of "complex infinity". But real infinity (of any sign) is clearly a wrong answer here (it has well defined finite phase and infinite absolute value), e.g.: ```pycon >>> ellippi(1-1e-15, 1-1e-15j) mpc(real='915673653288978.88', imag='-530451596311157.62') >>> ellippi(1-1e-15, 1+1e-15j) mpc(real='915673653288978.88', imag='530451596311157.62') ``` Closes mpmath#268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit fc474e1.
We don't have a concept of "complex infinity". But real infinity (of any sign) is clearly a wrong answer here (it has well defined finite phase and infinite absolute value), e.g.:
Closes #268