Add Fox H-function with rational A and B parameters#982
Merged
skirpichev merged 4 commits intompmath:masterfrom Jul 27, 2025
Merged
Add Fox H-function with rational A and B parameters#982skirpichev merged 4 commits intompmath:masterfrom
skirpichev merged 4 commits intompmath:masterfrom
Conversation
Collaborator
|
Be careful with a doctest example like this: Here the output is not actually |
Collaborator
I guess, you meant "input". I don't think this issue is too severe nowadays, as Python's float's are usually just IEEE doubles, i.e. doctest will be stable across systems (modulo bugs). But I also suggest using exact binary fractions, not |
Contributor
Author
|
Updated the doc example and tests. The difference in argument indeed causes some deviation in the result. |
skirpichev
reviewed
Jul 24, 2025
skirpichev
reviewed
Jul 25, 2025
Contributor
Author
|
Suggested changes applied. |
skirpichev
approved these changes
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #980
Please let me know if I missed anything.