Skip to content

[docs] Separate example folders for Core and Studio#4301

Merged
bharatkashyap merged 8 commits intomui:masterfrom
bharatkashyap:examples-separate
Oct 30, 2024
Merged

[docs] Separate example folders for Core and Studio#4301
bharatkashyap merged 8 commits intomui:masterfrom
bharatkashyap:examples-separate

Conversation

@bharatkashyap
Copy link
Collaborator

Closes #4298

@bharatkashyap bharatkashyap added the docs Improvements or additions to the documentation. label Oct 23, 2024
Copy link
Collaborator

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I gave it a quick check and maybe it's just missing updating the paths on the example READMEs?

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 29, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged. and removed PR: out-of-date The pull request has merge conflicts and can't be merged. labels Oct 30, 2024
…pad; branch 'master' of github.com:mui/mui-toolpad into examples-separate
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 30, 2024
@bharatkashyap bharatkashyap merged commit 37bc672 into mui:master Oct 30, 2024
@apedroferreira
Copy link
Collaborator

The studio example deployments in Railway seem to be failing in the CI in master: https://github.com/mui/toolpad/commits/master/
I guess we need to update the paths somewhere else?

@bharatkashyap
Copy link
Collaborator Author

The studio example deployments in Railway seem to be failing in the CI in master: https://github.com/mui/toolpad/commits/master/ I guess we need to update the paths somewhere else?

Yep, I noticed this as well (and flagged on Slack, I guess we can continue this there!) but couldn't investigate further without access to the Railway apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to the documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[examples] Separate the examples in two directories (core & studio)

2 participants