[DashboardLayout] Add branding prop as override#4442
Merged
apedroferreira merged 1 commit intomui:masterfrom Nov 20, 2024
apedroferreira:layout-branding-prop
Merged
[DashboardLayout] Add branding prop as override#4442apedroferreira merged 1 commit intomui:masterfrom apedroferreira:layout-branding-prop
apedroferreira merged 1 commit intomui:masterfrom
apedroferreira:layout-branding-prop
Conversation
apedroferreira
added
type: enhancement
bharatkashyap
approved these changes
Nov 20, 2024
Collaborator
|
@apedroferreira Missed mentioning that we should document this override prop in this section: https://mui.com/toolpad/core/react-dashboard-layout/#branding |
Collaborator
Author
Good point, we should do it, will add later! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small change just to try to address this old discussion: #4118
Add a
brandingprop toDashboardLayoutthat can be used to override theAppProviderbranding.Also slightly increased spacing between logo and title in the layout header bar, as I noticed it was currently too small for most logos.