[cli] Add framework selection to support Vite#4545
[cli] Add framework selection to support Vite#4545bharatkashyap merged 20 commits intomui:masterfrom
Conversation
bharatkashyap
added
the
create-toolpad-app
apedroferreira
left a comment
apedroferreira
left a comment
There was a problem hiding this comment.
Looks good, just some general suggestions, nothing too specific to the implementation that I could notice!
| # Toolpad Core - Vite & React Router | ||
|
|
||
| This template provides a minimal setup to get React working in Vite with HMR. | ||
| This example provides a minimal setup to get Toolpad Core working in Vite with HMR, as well as routing with React Router and a mock authentication setup. |
There was a problem hiding this comment.
Maybe we don't need this example anymore now that we have the Firebase one?
Or we can keep it if this one is more extendable, not sure.
There was a problem hiding this comment.
I feel like it's okay to preserve the barebones example just to demonstrate the minimum requirements to get auth working
|
|
||
| let routerOption: SupportedRouter | undefined; | ||
|
|
||
| if (frameworkOption === 'nextjs') { |
There was a problem hiding this comment.
Maybe the router and framework choice could be the same menu of choices? Unless we plan to have a lot of options for both in the future i guess...
There was a problem hiding this comment.
My preference would be to keep the options list short, so Next.js or Vite? -> App Router or Pages Router?
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Netlify deploy preview |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
3 participants
create-toolpad-app#4235