[PageHeader] Allow multiple breadcrumbs that are not links#4571
Merged
Janpot merged 10 commits intomui:masterfrom Jan 9, 2025
null93:patch-1
Merged
[PageHeader] Allow multiple breadcrumbs that are not links#4571Janpot merged 10 commits intomui:masterfrom null93:patch-1
Janpot merged 10 commits intomui:masterfrom
null93:patch-1
Conversation
Signed-off-by: Rafael Grigorian <[email protected]>
Signed-off-by: Rafael Grigorian <[email protected]>
Signed-off-by: Rafael Grigorian <[email protected]>
Janpot
reviewed
Jan 6, 2025
Changing key for Typography breadcrumb from `item.title` to `index` Signed-off-by: Rafael Grigorian <[email protected]>
Netlify deploy preview |
Janpot
approved these changes
Jan 7, 2025
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Rafael Grigorian <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply allows multiple breadcrumbs to exist that are not links. An application of this would be having a top level breadcrumb that you would not want to be a link but instead be static text.
For example, given this definition for breadcrumbs:
Before, the last breadcrumb was always static text and all breadcrumbs before it were links.
After, the breadcrumb is a link if it has a truthy value for
pathand it is static text if that value ofpathis falsy.