[docs] Fix redirection to GitHub example view#4642
Merged
oliviertassinari merged 1 commit intomui:masterfrom Jan 30, 2025
Merged
[docs] Fix redirection to GitHub example view#4642oliviertassinari merged 1 commit intomui:masterfrom
oliviertassinari merged 1 commit intomui:masterfrom
Conversation
oliviertassinari
added
docs
Comment on lines
-112
to
+111
| source: 'https://github.com/mui/toolpad/tree/master/examples/core/tutorial/', | ||
| source: 'https://github.com/mui/toolpad/tree/master/examples/core/tutorial', |
Member
Author
There was a problem hiding this comment.
GitHub supports both, they have no care for forcing one over the other, it's so cheap, lol, not even a canonical link.
In any case, here, we can use what their links default to.
x same as for the other diffs.
| <Button | ||
| component="a" | ||
| href={versionGitHubLink(example.href)} | ||
| href={example.href} |
Member
Author
There was a problem hiding this comment.
href are live demos, no need to handle them. It's only relevant for source.
Netlify deploy preview |
bharatkashyap
approved these changes
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4350 was a bit too rushed. This creates a ton of 301 in the ahrefs crawls: https://app.ahrefs.com/site-audit/3833384/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2CcontentType%2Cdepth%2Credirect%2CincomingAllLinks¤t=29-01-2025T022904&filterId=b3b75b6257a370fcf9f1f73befb5deb5&issueId=c64d8847-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating