Skip to content

[code-infra] Update package layout for ESM#4686

Merged
Janpot merged 16 commits intomui:masterfrom
Janpot:esm-layout
Feb 21, 2025
Merged

[code-infra] Update package layout for ESM#4686
Janpot merged 16 commits intomui:masterfrom
Janpot:esm-layout

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Feb 19, 2025 •
edited
Loading

Fixes #4675.
Fixes mui/material-ui#45300

Bring in mui/material-ui#43264 for core and utils. ignoring the studio packages for now.

  • had to convert @toolpad/utils as well as it's a dependency of @toolpad/core
  • had to update monorepo, which had a bunch of hanging changes:
    • bring in changes for docs/config update
    • bring in changes for next.config.ts
    • bring eslint update
  • updated core lib to be able to remove the labs dependency, this fixes issues of lab not being a peer dependency

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Feb 19, 2025
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 19, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Feb 19, 2025
@mui-bot
Copy link

mui-bot commented Feb 19, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-4686--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against b5c4868

@Janpot Janpot mentioned this pull request Feb 19, 2025
Closed
@Janpot Janpot marked this pull request as ready for review February 19, 2025 17:40
@Janpot Janpot mentioned this pull request Feb 19, 2025
Closed
@Janpot Janpot requested a review from a team February 19, 2025 18:11
@Janpot Janpot merged commit 1ad5b75 into mui:master Feb 21, 2025
15 checks passed
@Janpot Janpot deleted the esm-layout branch February 21, 2025 17:12
@Janpot Janpot mentioned this pull request Feb 25, 2025
Closed
@marcomele
Copy link

marcomele commented Mar 9, 2025 •
edited
Loading

Not sure if I'm missing something, but I'm pretty sure something among these changes is breaking NextJS imports:

 ⨯ [Error: Cannot find module '/Users/<redacted>/node_modules/next/compat/router' imported from /Users/<redacted>/node_modules/@toolpad/core/esm/nextjs/NextAppProvider.js
Did you mean to import "next/compat/router.js"?] {
  code: 'ERR_MODULE_NOT_FOUND',
  url: 'file:///Users/<redacted>/node_modules/next/compat/router',
  page: '/store/products/1041'
}

yarn: '1.22.22',
node: '20.15.1',
@toolpad/core: '0.12.1',
next: '^15.2.1',
react: '^19.0.0',
typescript: '^5.7.3'

@Janpot
Copy link
Member Author

Janpot commented Mar 9, 2025

Right, I missed this, apologies. Same issue as why we do this in @mui/material-nextjs.

It would likely be enough to just add a .js extension to this import:

toolpad/packages/toolpad-core/src/nextjs/NextAppProvider.tsx

Line 3 in 7932870

import { useRouter } from 'next/compat/router';

@Janpot Janpot mentioned this pull request Mar 10, 2025
Merged
@Janpot Janpot mentioned this pull request Apr 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Import error when using Material UI styles with React router v7 framework Import error when using Material UI styles with React router v7 framework

4 participants

@Janpot @mui-bot @marcomele @apedroferreira