Skip to content

[code-infra] Revert ESM update for toolpad-core#4745

Merged
apedroferreira merged 12 commits intomui:masterfrom
Janpot:next-esm
Mar 11, 2025
Merged

[code-infra] Revert ESM update for toolpad-core#4745
apedroferreira merged 12 commits intomui:masterfrom
Janpot:next-esm

Conversation

@Janpot
Copy link
Member

@Janpot Janpot commented Mar 10, 2025 •
edited
Loading

Wait for both X and core to be in beta with their updated package layout before making this change to @toolpad/core. We can keep it for @toolpad/utils.

@Janpot Janpot added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Mar 10, 2025
@mui-bot
Copy link

mui-bot commented Mar 10, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-4745--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against bcfb7d3

@Janpot Janpot marked this pull request as ready for review March 10, 2025 10:50
apedroferreira
apedroferreira approved these changes Mar 10, 2025
View reviewed changes
Copy link
Collaborator

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I had actually ran into this too but wasn't sure if this was the fix.

@apedroferreira
Copy link
Collaborator

apedroferreira commented Mar 10, 2025 •
edited
Loading

Oh wait, I guess we need to update the versions for development, the playground apps and the examples accordingly?
And create-toolpad-app.
But I can take care of that.

@Janpot
Copy link
Member Author

Janpot commented Mar 10, 2025

Oh wait, I guess we need to update the versions

Yes, and I haven't tested what this does for Studio

@apedroferreira
Copy link
Collaborator

apedroferreira commented Mar 10, 2025

Oh wait, I guess we need to update the versions

Yes, and I haven't tested what this does for Studio

Hopefully nothing too breaking, I'll try in a separate PR.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 10, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 10, 2025
@apedroferreira apedroferreira mentioned this pull request Mar 10, 2025
Closed
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 11, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Mar 11, 2025
@Janpot Janpot changed the title [code-infra] Fix next esm resolution [code-infra] Revert ESM update for toolpad-core Mar 11, 2025
@Janpot
Copy link
Member Author

Janpot commented Mar 11, 2025

@apedroferreira I'm reverting this until X publishes their beta. Core v7 is not compatible with X v7.

@apedroferreira
Copy link
Collaborator

apedroferreira commented Mar 11, 2025

Seems to have fixed the issue, just tested with the CodeSandbox version!

The dev scripts in toolpad-core and toolpad-utils are still broken but they already were since the scripts it uses changed so it doesn't need to block this. I guess we will need some kind of alternative there, didn't look to deep into it yet.

@Janpot
Copy link
Member Author

Janpot commented Mar 11, 2025

I guess we will need some kind of alternative there, didn't look to deep into it yet.

I'll fix this in core

@apedroferreira apedroferreira merged commit 657ab8f into mui:master Mar 11, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees

No one assigned

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Janpot @mui-bot @apedroferreira