fix: render divider and header as li in menu#4763
fix: render divider and header as li in menu#4763apedroferreira merged 12 commits intomui:masterfrom
Conversation
apedroferreira
left a comment
There was a problem hiding this comment.
Hi, you're right, thanks a lot for finding these issues and working on the fixes!
All good, just a small change in the order of props to be consistent.
packages/toolpad-core/src/DashboardLayout/DashboardSidebarSubNavigation.tsx
Outdated
Show resolved
Hide resolved
packages/toolpad-core/src/DashboardLayout/DashboardSidebarSubNavigation.tsx
Outdated
Show resolved
Hide resolved
Netlify deploy preview |
|
There's a failing CI check, sorry, can you please run |
… github.com:rkristelijn/toolpad into feature/render-divider-as-li-in-menu-and-header-too
|
I've ran Weirdly enough there is no pnpm dependency, so i ran against the latest which is 9.12.3. I would recommend to either:
|
Yes, looks like we could improve the documentation about suggestion 1 at least. Feel free to even submit a PR with that or I can do it soon! Other than that we do have |
Closes #4759