[core] [i18n] Add interpolation to translation keys#4773
[core] [i18n] Add interpolation to translation keys#4773bharatkashyap merged 8 commits intomui:masterfrom
Conversation
bharatkashyap
added
the
i18n
Netlify deploy preview |
| { | ||
| "props": { "localeText": { "type": { "name": "object" } } }, | ||
| "props": { | ||
| "localeText": { |
There was a problem hiding this comment.
Can we keep this type the same as in X?
| /** | ||
| * Locale for components texts | ||
| */ | ||
| localeText: PropTypes.object, |
There was a problem hiding this comment.
I believe this was deliberate, as in https://github.com/mui/mui-x/blob/7b956af2cf425c4b8a21cee6876f448e3337026f/packages/x-date-pickers/src/TimePicker/TimePicker.tsx#L135
There was a problem hiding this comment.
Yes, but I felt that having the explicit props is helpful at least on the LocalizationProvider docs, it is typed as object for every other component. We can revert it if you think it doesn't make sense
There was a problem hiding this comment.
We can revert it if you think it doesn't make sense
It makes sense, but I think it makes more sense to be consistent with X
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
I believe the proptype of localeText was deliberate
3 participants
providerSignInTitleof a(provider: string) => stringtypesignInTitleto astring | ((brandingTitle?: string) => string)typeBreaking Change
oauthSignInTitle,passkeySignInTitleandmagicLinkSignInTitle