[docs] Add CRUD to themed example#4785
Conversation
bharatkashyap
added
docs
Netlify deploy preview |
| }, [listPath, router]); | ||
|
|
||
| return ( | ||
| <CrudProvider<Employee> dataSource={employeesDataSource} dataSourceCache={employeesCache}> |
There was a problem hiding this comment.
I'll expose the dataGrid slot to the Crud component so we can just use that component here.
There was a problem hiding this comment.
Feel free to just add a TODO comment here for this for now as i guess we will only be able to adjust here after the next release once we merge #4786
There was a problem hiding this comment.
Looks good! Just noticed a few things that probably we can improve:
- Add:
import PersonIcon from '@mui/icons-material/Person';
// ...
{
segment: 'employees',
title: 'Employees',
icon: <PersonIcon />,
pattern: 'employees{/:employeeId}*',
},
// ...to the navigation to show employees pages and breadcrumbs.
- There's no spacing above and below the action icon buttons, not sure if we should solve that in the template itself or in the CRUD components? (just checked and all looks fine in the standard version so I guess we can fix it somehow for this template)
- The form input labels need spacing below, I guess this one should probably be fixed in the template?
Thanks! Addressed all of this in the theme of the template |
|
Thanks for the changes!
Screen.Recording.2025-03-21.at.17.18.54.mov |
apedroferreira
left a comment
apedroferreira
left a comment
There was a problem hiding this comment.
I've addressed my own suggestions since Bharat is out.
5 participants
Crud