Skip to content

[examples] Use REST API for CRUD in themed example#4834

Merged
bharatkashyap merged 8 commits intomui:masterfrom
bharatkashyap:fix/auth-nextjs-themed-v2
Apr 21, 2025
Merged

[examples] Use REST API for CRUD in themed example#4834
bharatkashyap merged 8 commits intomui:masterfrom
bharatkashyap:fix/auth-nextjs-themed-v2

Conversation

@bharatkashyap
Copy link
Collaborator

@bharatkashyap bharatkashyap commented Apr 8, 2025

@bharatkashyap bharatkashyap changed the title [examples Bring changes from #4826 [examples] Use REST API in themed example Apr 8, 2025
@bharatkashyap bharatkashyap changed the title [examples] Use REST API in themed example [examples] Use REST API for CRUD in themed example Apr 8, 2025
@bharatkashyap bharatkashyap added the examples Relating to /examples. label Apr 8, 2025
@mui-bot
Copy link

mui-bot commented Apr 8, 2025

Netlify deploy preview

https://deploy-preview-4834--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against e5233b5

@bharatkashyap bharatkashyap requested a review from Janpot April 9, 2025 17:23
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 11, 2025
@bharatkashyap bharatkashyap moved this to In progress in Toolpad public roadmap Apr 11, 2025
@Janpot Janpot requested a review from apedroferreira April 14, 2025 14:45
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 14, 2025
@apedroferreira
Copy link
Collaborator

apedroferreira commented Apr 16, 2025

Non-blocking and probably don't really have to be fixed quick if there's other priorities, but found 2 visual nitpicks:

1. Background color behind sidebar subtitles:
Screenshot 2025-04-16 at 00 59 41

2. Border around date icon inside date inputs:
Screenshot 2025-04-16 at 00 59 31

@bharatkashyap
Copy link
Collaborator Author

  1. is a quick fix but 👇🏻 requires the ability to customise the date component being used specifically in the Edit component - not sure if we can do that with Crud at the moment. Is there a quick way I'm missing?

2. Border around date icon inside date inputs: Screenshot 2025-04-16 at 00 59 31

@apedroferreira
Copy link
Collaborator

apedroferreira commented Apr 17, 2025

  1. is a quick fix but 👇🏻 requires the ability to customise the date component being used specifically in the Edit component - not sure if we can do that with Crud at the moment. Is there a quick way I'm missing?

I thought it was more of a theming issue and would happen in every input with icons, or can't we just target the icon in the MUI X date pickers somehow?

@bharatkashyap
Copy link
Collaborator Author

  1. is a quick fix but 👇🏻 requires the ability to customise the date component being used specifically in the Edit component - not sure if we can do that with Crud at the moment. Is there a quick way I'm missing?

I thought it was more of a theming issue and would happen in every input with icons, or can't we just target the icon in the MUI X date pickers somehow?

It is an intentional choice for the other icon buttons so just this icon button is to be targeted - I can try and look more deeply if we can target just the MUI X Date Picker Icon button

@apedroferreira
Copy link
Collaborator

  1. is a quick fix but 👇🏻 requires the ability to customise the date component being used specifically in the Edit component - not sure if we can do that with Crud at the moment. Is there a quick way I'm missing?

I thought it was more of a theming issue and would happen in every input with icons, or can't we just target the icon in the MUI X date pickers somehow?

It is an intentional choice for the other icon buttons so just this icon button is to be targeted - I can try and look more deeply if we can target just the MUI X Date Picker Icon button

If it's intentional we can keep it, I thought it was unintended just because the border gets a bit thicker on the right. Anyway it's a real nitpick probably :D

@bharatkashyap
Copy link
Collaborator Author

  1. is a quick fix but 👇🏻 requires the ability to customise the date component being used specifically in the Edit component - not sure if we can do that with Crud at the moment. Is there a quick way I'm missing?

I thought it was more of a theming issue and would happen in every input with icons, or can't we just target the icon in the MUI X date pickers somehow?

It is an intentional choice for the other icon buttons so just this icon button is to be targeted - I can try and look more deeply if we can target just the MUI X Date Picker Icon button

If it's intentional we can keep it, I thought it was unintended just because the border gets a bit thicker on the right. Anyway it's a real nitpick probably :D

The borders on the general icon buttons are intentional, this one indeed is a bit problematic - I'll look into targeting it with some selectors and remove it. Nitpicks are always welcome 🕵🏻

@bharatkashyap bharatkashyap merged commit f16af42 into mui:master Apr 21, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Completed in Toolpad public roadmap Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples Relating to /examples.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants