Skip to content

Update dependencies in create-toolpad-app and examples#4863

Merged
apedroferreira merged 2 commits intomui:masterfrom
apedroferreira:update-mui-deps
Apr 21, 2025
Merged

Update dependencies in create-toolpad-app and examples#4863
apedroferreira merged 2 commits intomui:masterfrom
apedroferreira:update-mui-deps

Conversation

@apedroferreira
Copy link
Collaborator

@apedroferreira apedroferreira commented Apr 18, 2025

Closes #4841

Also the latest version of create-toolpad-app isn't working for me because the dependencies there were never updated to match the latest release versions... I thought that something like this would have been caught during the release.
But this should fix it.

@apedroferreira apedroferreira added internal Behind-the-scenes enhancement. Formerly called “core”. examples Relating to /examples. create-toolpad-app Issues related to the `create-toolpad-app` CLI tool scope: toolpad-core Abbreviated to "core" labels Apr 18, 2025
@apedroferreira apedroferreira self-assigned this Apr 18, 2025
@apedroferreira apedroferreira added the type: bug It doesn't behave as expected. label Apr 18, 2025
@mui-bot
Copy link

mui-bot commented Apr 18, 2025

Netlify deploy preview

https://deploy-preview-4863--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 07e6b10

@apedroferreira
Copy link
Collaborator Author

apedroferreira commented Apr 18, 2025

Looks like it fixes #4841 if there was an issue (I never managed to reproduce it).

I've tried the Vite and Next.js starters without authentication and all looks good:
Screenshot 2025-04-18 at 18 08 37

@apedroferreira apedroferreira marked this pull request as ready for review April 18, 2025 17:06
@apedroferreira apedroferreira requested a review from a team April 18, 2025 17:06
@bharatkashyap
Copy link
Collaborator

Closes #4841

Also the latest version of create-toolpad-app isn't working for me because the dependencies there were never updated to match the latest release versions... I thought that something like this would have been caught during the release. But this should fix it.

I think a way to future-proof the release to check for this is to add an --example test to the smoke tests to test not just the bootstrapping of new apps but also if the examples have been updated correctly: https://github.com/mui/mui-toolpad/blob/master/RELEASE.md

Copy link
Collaborator

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicit versions work better than latest since latest can mean different things in dependency managers' caches

@apedroferreira
Copy link
Collaborator Author

Closes #4841
Also the latest version of create-toolpad-app isn't working for me because the dependencies there were never updated to match the latest release versions... I thought that something like this would have been caught during the release. But this should fix it.

I think a way to future-proof the release to check for this is to add an --example test to the smoke tests to test not just the bootstrapping of new apps but also if the examples have been updated correctly: https://github.com/mui/mui-toolpad/blob/master/RELEASE.md

I think the examples are fine to update later, but in the current version even running npx create-toolpad-app seems to fail for me.

@apedroferreira apedroferreira merged commit 283a936 into mui:master Apr 21, 2025
15 checks passed
@apedroferreira apedroferreira deleted the update-mui-deps branch April 21, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-toolpad-app Issues related to the `create-toolpad-app` CLI tool examples Relating to /examples. internal Behind-the-scenes enhancement. Formerly called “core”. scope: toolpad-core Abbreviated to "core" type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CRUD] Incorrect spacing of edit/list view

3 participants