Skip to content

[CRUD] Show correct single-select values in "Show" UI#4876

Merged
apedroferreira merged 6 commits intomui:masterfrom
apedroferreira:fix-show-single-select
Apr 25, 2025
Merged

[CRUD] Show correct single-select values in "Show" UI#4876
apedroferreira merged 6 commits intomui:masterfrom
apedroferreira:fix-show-single-select

Conversation

@apedroferreira
Copy link
Collaborator

@apedroferreira apedroferreira commented Apr 21, 2025

Closes #4806

Show proper singleSelect field value in CRUD "Show" UI when option values are provided as an object.
Adds tests to cover these scenarios.

Unrelated fix included: stop sidebar headers text from ellipsizing when collapsing the sidebar to mini version. It's happening in the latest docs such as https://deploy-preview-4864--mui-toolpad-docs.netlify.app/toolpad/core/react-dashboard-layout/#demo

@apedroferreira apedroferreira added type: bug It doesn't behave as expected. scope: toolpad-core Abbreviated to "core" component: crud labels Apr 21, 2025
@apedroferreira apedroferreira self-assigned this Apr 21, 2025
@apedroferreira apedroferreira changed the title Fix showing single-select values, add tests [CRUD] Show correct single-select values in "Show" UI Apr 21, 2025
@mui-bot
Copy link

mui-bot commented Apr 21, 2025

Netlify deploy preview

https://deploy-preview-4876--mui-toolpad-docs.netlify.app/

Generated by 🚫 dangerJS against 081d839

@apedroferreira apedroferreira requested a review from a team April 21, 2025 14:54
@bharatkashyap
Copy link
Collaborator

Should we add a demo in the CRUD docs to illustrate this behaviour?

@apedroferreira
Copy link
Collaborator Author

Should we add a demo in the CRUD docs to illustrate this behaviour?

I don't think so, it's just a different way to configure multi-select fields but it's the same as for the MUI X Data Grid. What we have in the demos is enough in my opinion.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 22, 2025
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Apr 22, 2025
@apedroferreira apedroferreira merged commit fe24044 into mui:master Apr 25, 2025
15 checks passed
@apedroferreira apedroferreira deleted the fix-show-single-select branch April 25, 2025 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: toolpad-core Abbreviated to "core" type: bug It doesn't behave as expected.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SingleSelect type does not show properly when using value options or custom data structures

3 participants