[DashboardLayout] Remove DashboardLayout navigation prop#4881
Merged
apedroferreira merged 9 commits intomui:masterfrom Apr 30, 2025
apedroferreira:remove-layout-navigation-prop
Merged
[DashboardLayout] Remove DashboardLayout navigation prop#4881apedroferreira merged 9 commits intomui:masterfrom apedroferreira:remove-layout-navigation-prop
DashboardLayout navigation prop#4881apedroferreira merged 9 commits intomui:masterfrom
apedroferreira:remove-layout-navigation-prop
Conversation
apedroferreira
added
scope: toolpad-core
Netlify deploy preview |
Janpot
reviewed
Apr 29, 2025
| * @default [] | ||
| * @deprecated Set the navigation in the [AppProvider](https://mui.com/toolpad/core/react-app-provider) instead. | ||
| */ | ||
| navigation?: Navigation; |
Member
There was a problem hiding this comment.
Probably also want to show a warning at runtime.
Janpot
reviewed
Apr 29, 2025
| sx, | ||
| } = props; | ||
|
|
||
| React.useEffect(() => { |
Member
There was a problem hiding this comment.
This should only run in development, and we also have this utility. Doesn't seem to be used anywhere though
Collaborator
Author
There was a problem hiding this comment.
didn't know about it, used it here, I guess it should be used on render like this? de4d2c7
Janpot
reviewed
Apr 29, 2025
Janpot
approved these changes
Apr 29, 2025
Member
Janpot
left a comment
Janpot
left a comment
There was a problem hiding this comment.
We always use process.env.NODE_ENV !== 'production'
bharatkashyap
approved these changes
Apr 30, 2025
Co-authored-by: Jan Potoms <[email protected]> Signed-off-by: Pedro Ferreira <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate
navigationprop inDashboardLayoutfor the next 2 versions.The
navigationshould always be set in theAppProviderinstead.Closes #4856