[AppProvider] Make theming not require specific HTML attribute name#4910
Merged
apedroferreira merged 3 commits intomui:masterfrom Apr 30, 2025
apedroferreira:improve-theming
Merged
[AppProvider] Make theming not require specific HTML attribute name#4910apedroferreira merged 3 commits intomui:masterfrom apedroferreira:improve-theming
apedroferreira merged 3 commits intomui:masterfrom
apedroferreira:improve-theming
Conversation
apedroferreira
added
docs
Netlify deploy preview |
apedroferreira
changed the title
bharatkashyap
approved these changes
Apr 30, 2025
github-project-automation
bot
moved this from In progress
to Completed
in Toolpad public roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized that we probably were requiring the CSS selector in the theme to be
data-toolpad-color-schemebut this shouldn't be necessary...Also removed a line from the theming docs that should be outdated by now.