Use named imports for locales#4945
Merged
bharatkashyap merged 5 commits intomui:masterfrom May 21, 2025
Merged
Conversation
Netlify deploy preview |
Contributor
Author
|
Also I'm going to send anothor PR to translate Japanese, if this PR was merged. |
Collaborator
|
Thanks for the contribution! Tested the localization demo with the named import - works |
bharatkashyap
approved these changes
May 19, 2025
Contributor
Author
|
@bharatkashyap I have a question for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds an
index.jsfile under thelocales/directory to explicitly export available locale modules (currentlyhiIN). This enables imports like:Motivation
Previously, consumers attempting to
import @toolpad/core/localesencountered errors because:but this method matches how Material UI locales are imported.
As a result, valid-looking import paths like:
would fail at runtime
This PR fixes that by introducing an explicit index that re-exports the locales,
Changes
locales/index.jsthat re-exportshiINBenefits
Notes
This fix avoids having to restructure each locale into its own folder or clutter the
exportsfield with specific entries. It keeps the implementation simple while solving a real usability issue.