UIRuntime: unnecessary required parameters#108
Merged
dg merged 1 commit intonette:masterfrom Jan 20, 2016
vitkutny:vitkutny-patch-1
Merged
UIRuntime: unnecessary required parameters#108dg merged 1 commit intonette:masterfrom vitkutny:vitkutny-patch-1
dg merged 1 commit intonette:masterfrom
vitkutny:vitkutny-patch-1
Conversation
Contributor
There was a problem hiding this comment.
This is actually not needed, isset covers it already: https://3v4l.org/EdJa5
Contributor
Author
There was a problem hiding this comment.
Thank you, updated
Member
|
Why? |
Contributor
Author
|
I know it's marked as |
dg
added a commit
that referenced
this pull request
Jan 20, 2016
UIRuntime: unnecessary required parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.