[RFC] Added possibility to configure PresenterFactory mapping via array#119
Conversation
Author
|
(Still in progress.) I realize this must be written differentlly, Parts of array must be validated and this must be allowed: $factory->setMapping([
'*' => ['App\\', '*'],
]);
Assert::same('App\RedDwarf', $factory->formatPresenterClass('RedDwarf')); |
Author
|
Ok, there is a proof of concept solution (I moved from red to greeen). Plase give me some feedback if I didn't miss any case or if there any missing functionality. Then I'll do some code cleaning & refactoring. I would like to extract the logic of parsing into some " |
Member
|
Ref #101 |
Contributor
|
@achse can you please simplify this? is an array with 1 and 2 items really necessary? I think the version with 3 items is sufficient. |
Author
|
I am very busy right now. Please, anyone is free to fork my PR and finish it or write it from scratch. Just tell here, to prevent simultanous work. I dont know when I get time to finish this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BC break: no
Documentation: needed
Solves: #101