Merged
Conversation
Member
|
Can you change commit message to smthng like |
Contributor
Author
|
@dg Done. |
Member
|
Btw it is required by storeRequest() & restoreRequest() |
Contributor
Author
|
@dg Added some conditions to make them work without user. |
Member
|
Did you test it? |
Contributor
Author
|
Oh right... can't use getUser because it throws an exception... Added a test for storeRequest as well. There are no existing tests for restoreRequest. Can't really test it in a real application though. I use my own implementation of these methods to make them work with object parameters. |
Contributor
|
Needs rebase after force-pushes... :( |
dg
pushed a commit
that referenced
this pull request
May 3, 2016
dg
pushed a commit
that referenced
this pull request
May 3, 2016
Member
|
Thanks, merged |
| } while (isset($session[$key])); | ||
|
|
||
| $session[$key] = [$this->getUser()->getId(), $this->request]; | ||
| $session[$key] = [$this->user ? $this->user->getId() : null, $this->request]; |
Contributor
Author
There was a problem hiding this comment.
Yeah, @dg already fixed that when he merged it. :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell nette/security seems to be optional everywhere in nette/application.