Updated netteForms.js to conform with PHP validation#174
Merged
dg merged 1 commit intonette:masterfrom Feb 6, 2018
hubipe:master
Merged
Updated netteForms.js to conform with PHP validation#174dg merged 1 commit intonette:masterfrom hubipe:master
dg merged 1 commit intonette:masterfrom
hubipe:master
Conversation
Member
|
Thanks! |
dg
pushed a commit
that referenced
this pull request
Feb 6, 2018
dg
pushed a commit
that referenced
this pull request
Feb 6, 2018
dg
pushed a commit
that referenced
this pull request
Mar 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JS validation in netteForms.js of FLOAT rule has been thrown, if value in input field contained more than 1 space, because String.replace(string, ...) replaces only first occurrence of given string. PHP method Validator::validateFloat on the other hand uses PHP method str_replace, which replaces all occurances of space in the input value (https://github.com/nette/forms/blob/master/src/Forms/Validator.php#L284).
I updated the JS String.replace inputs to replace all occurrences in the input value, not just first one. I also updated the regexp itself to be the same as the implementation in PHP (https://github.com/nette/utils/blob/master/src/Utils/Validators.php#L196)