Forms: Selectbox allow item with null caption [ID => null]#4
Merged
dg merged 1 commit intonette:masterfrom Apr 18, 2014
Merged
Conversation
Contributor
|
Why not just use empty string? |
Contributor
Author
|
Sorry for the second commit, I'll try to remove it.. Well, it's a bug. |
Contributor
There was a problem hiding this comment.
=> not ,
Edit: Actually the second item is irrelevant.
Contributor
|
It would make more sense to sanitize options in Select. Here null value is a duplicate to empty string. |
Contributor
Author
|
@mishak87 Typo, it wasn't meant to be 3 items. |
Contributor
Author
|
Can You please accept or reject this pull request? If you'll reject, please fix the bug described in the test case. |
Member
|
I'll merge it, but please squash it to single commit and use uppercased NULL in tests. |
Forms: test fix, test for ChoiseControl Forms: Coding standard fix NULL should be uppercase
Contributor
Author
|
Done, thanks |
Member
|
Thx ! |
dg
added a commit
that referenced
this pull request
Apr 18, 2014
Forms: Selectbox allow item with null caption [ID => null]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.