See https://secure.php.net/manual/en/function.http-response-code.php#114996

I'd rather use default reason for each code or empty string for unknown codes.
And maybe also add 2nd optional parameter $reason to allow custom reason override.
That'd match what Symfony does by the way.

It seems that it is related to webserver. It works with Apache or CGI and doesn't work with nginx.

Yep, it doesn't work in nginx + php-fpm, I don't know about Apache. But the code is obviously missing the additional required space:

header($protocol . ' ' . $code, TRUE, $code);

Maybe Apache appends it automatically and nginx doesn't, but I don't expect my webserver to do that.

Yes, because it was completed automatically, I've used this solution. I didn't know it doesn't work with nginx. Thanks for the fix.

Great, thanks! 👍

@dg @ondrejmirtes This change is a BC break for people running PHP as an Apache module. See https://secure.php.net/manual/en/function.http-response-code.php#114996 for details.

Edit: So, it turns out it is probably not a BC break, because $httpResponse->setCode(418) never worked with apache2handler SAPI.

The apache2handler SAPI converts header('HTTP/1.1 404') to HTTP/1.1 404 Not Found, however header('HTTP/1.1 418') does not work, you need to write header('HTTP/1.1 418 I\'m A Teapot').

So I think that best we can do, is to change the setCode() methods to sth like

public function setCode($code, $reasonPhrase = NULL)
{
	$code = (int) $code;
	if ($code < 100 || $code > 599) {
		throw new Nette\InvalidArgumentException("Bad HTTP response '$code'.");
	}
	self::checkHeaders();
	$this->code = $code;

	if ($reasonPhrase !== NULL) {
		$protocol = isset($_SERVER['SERVER_PROTOCOL']) ? $_SERVER['SERVER_PROTOCOL'] : 'HTTP/1.1';
		header("$protocol $code $reasonPhrase", TRUE, $code);
	
	} else {
		http_response_code($code);	
	}
	
	return $this;
}

@JanTvrdik http_response_code() works the same way as header() worked.

@JanTvrdik I have added something similar.