Adds the plus character as a valid option in numeric strings#184
Merged
dg merged 3 commits intonette:masterfrom Mar 6, 2019
Amunak:Amunak-patch-1
Merged
Adds the plus character as a valid option in numeric strings#184dg merged 3 commits intonette:masterfrom Amunak:Amunak-patch-1
dg merged 3 commits intonette:masterfrom
Amunak:Amunak-patch-1
Conversation
Contributor
Author
|
It would appear that your Travis test image is broken. |
Member
|
Thanks |
dg
pushed a commit
that referenced
this pull request
Mar 12, 2019
dg
pushed a commit
that referenced
this pull request
Mar 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For whatever reason numeric strings with explicitly positive values (i.e.
+1instead of just1) have not been considered as valid numerics even though they are perfectly valid (in the sense that even forcibly changing their type to the respective numeric type works as expected).This PR fixes that issue, adding consistency with PHP and the way numbers can be written to the Validator class.
I have marked this as "not bc breaking" because (1) this use case has not been covered by tests, so it doesn't change any and (2) nobody should accept
'-1'as a valid value and expect'+1'to fail.Please merge this with squash; I accidentally made one too many commits.