Skip to content

Fix for to_gedcom_string()#29

Merged
nickreynke merged 3 commits intonickreynke:developfrom
KeithPetro:master
Mar 13, 2020
Merged

Fix for to_gedcom_string()#29
nickreynke merged 3 commits intonickreynke:developfrom
KeithPetro:master

Conversation

@KeithPetro
Copy link

Fix for #27. This should fix an issue where calling to_gedcom_string() for the ROOT element resulted in an empty string. Recursion was also broken and has been fixed.

@KeithPetro
Copy link
Author

Looks like the Travis build failed. I'll look into that as soon as I am able to get on my computer again.

Removed whitespace
@gburca
Copy link

gburca commented Dec 1, 2019

Any plans to merge this in?

@KeithPetro
Copy link
Author

Looking over my changes quickly, I think it would've been smarter to just return result instead of returning ''. I think there is an issue with this change, as there is no base return condition if recursive is True. I don't know how I missed that in my original testing.

@mameen
Copy link

mameen commented Feb 17, 2020

identical fix + test cases : mameen@9fcd894

@KeithPetro
Copy link
Author

Hey @nickreynke, any chance of getting this merged in?

@mameen If you're good with it, I can either add you as a contributor to my fork so you can push your tests to this PR, or I could push the tests myself.

@mameen
Copy link

mameen commented Mar 12, 2020

@KeithPetro you are welcome to cherrypick the fix from my fork.. I lost interest in the project :-D

@nickreynke nickreynke merged commit c4fd803 into nickreynke:develop Mar 13, 2020
@nickreynke
Copy link
Owner

@KeithPetro and @mameen: I'm very sorry for the late reply. Due to some private problems, I experienced the last months, I didn't get the time to maintain the project. I'll publish a new version to Pypi later this day. Thank you for contributing!

@mameen
Copy link

mameen commented Mar 13, 2020

@nickreynke I hope things are good now, and thanks for looking after this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants