tools: enforce linebreak after ternary operators#10213
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
tools: enforce linebreak after ternary operators#10213targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
This is to be consistent with the other operators and helps understanding the context when the code is grepped.
nodejs-github-bot
added
dont-land-on-v7.x
repl
bnoordhuis
approved these changes
Dec 10, 2016
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM. eslint doesn't enforce four space indent after a linebreak?
Member
Author
I'm not sure. The indent rule has a lot options, some of them being off by default. Maybe @not-an-aardvark can answer? |
targos
added
tools
cjihrig
approved these changes
Dec 10, 2016
thefourtheye
approved these changes
Dec 10, 2016
Contributor
thefourtheye
left a comment
thefourtheye
left a comment
There was a problem hiding this comment.
LGTM if CI is happy.
Contributor
Correct, this is currently ignored by the |
not-an-aardvark
approved these changes
Dec 10, 2016
Member
Author
Member
|
I find this a lot less readable but it's only my personal preference, not a problem. |
Contributor
|
I actually find this significantly harder to read... 😕 👎 |
Contributor
|
I guess it's consistent with how we do |
jasnell
approved these changes
Dec 23, 2016
jasnell
pushed a commit
that referenced
this pull request
Dec 23, 2016
This is to be consistent with the other operators and helps understanding the context when the code is grepped. PR-URL: #10213 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 966e5cf. |
thefourtheye
added a commit
that referenced
this pull request
Dec 23, 2016
test-whatwg-url-parsing file violates the linter rule changes in #10213. This patch makes the linter happy. PR-URL: #10421 Reviewed-By: Anna Henningsen <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
This is to be consistent with the other operators and helps understanding the context when the code is grepped. PR-URL: #10213 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
test-whatwg-url-parsing file violates the linter rule changes in #10213. This patch makes the linter happy. PR-URL: #10421 Reviewed-By: Anna Henningsen <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
This is to be consistent with the other operators and helps understanding the context when the code is grepped. PR-URL: #10213 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: James M Snell <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
test-whatwg-url-parsing file violates the linter rule changes in #10213. This patch makes the linter happy. PR-URL: #10421 Reviewed-By: Anna Henningsen <[email protected]>
Contributor
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport edit: if it does land it may need to come with #10421 on v6.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesDescription of change
This is to be consistent with the other operators and helps
understanding the context when the code is grepped.