doc: add STYLE_GUIDE (moved from nodejs/docs)#11321
Closed
gibfahn wants to merge 1 commit intonodejs:masterfrom
Closed
doc: add STYLE_GUIDE (moved from nodejs/docs)#11321gibfahn wants to merge 1 commit intonodejs:masterfrom
gibfahn wants to merge 1 commit intonodejs:masterfrom
Conversation
Contributor
|
Would it be better to link this in CONTRIBUTING.md? |
jasnell
approved these changes
Feb 12, 2017
Also add a reference in CONTRIBUTING.md to it.
jasnell
pushed a commit
that referenced
this pull request
Feb 16, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: #11321 Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in ca5215e |
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Feb 20, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: nodejs#11321 Reviewed-By: James M Snell <[email protected]>
italoacasas
pushed a commit
that referenced
this pull request
Feb 22, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: #11321 Reviewed-By: James M Snell <[email protected]>
Merged
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: #11321 Reviewed-By: James M Snell <[email protected]>
jasnell
pushed a commit
that referenced
this pull request
Mar 7, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: #11321 Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: #11321 Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
Also add a reference in CONTRIBUTING.md to it. PR-URL: #11321 Reviewed-By: James M Snell <[email protected]>
Merged
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 6, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 6, 2022
Refs: #11321 Refs: #17384 PR-URL: #42989 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 7, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 8, 2022
Refs: #11321 Refs: #17384 PR-URL: #43001 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 9, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 9, 2022
Refs: #11321 Refs: #17384 PR-URL: #43026 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
RafaelGSS
pushed a commit
that referenced
this pull request
May 10, 2022
Refs: #11321 Refs: #17384 PR-URL: #42989 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43242 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43145 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43154 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43179 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43191 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43220 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
bengl
pushed a commit
that referenced
this pull request
May 30, 2022
Refs: #11321 Refs: #17384 PR-URL: #43242 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
tniessen
added a commit
to tniessen/node
that referenced
this pull request
May 30, 2022
nodejs-github-bot
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43257 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #42989 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43001 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43026 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43048 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43063 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43103 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43113 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: LiviaMedeiros <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43104 Reviewed-By: LiviaMedeiros <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43145 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43154 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Refs: #11321 Refs: #17384 PR-URL: #43179 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
F3n67u
pushed a commit
to F3n67u/node
that referenced
this pull request
Jun 1, 2022
Refs: nodejs#11321 Refs: nodejs#17384 PR-URL: nodejs#43242 Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Darshan Sen <[email protected]>
F3n67u
pushed a commit
to F3n67u/node
that referenced
this pull request
Jun 1, 2022
Refs: nodejs#11321 Refs: nodejs#17384 PR-URL: nodejs#43257 Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Jun 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description:
Moves the STYLE_GUIDE.md from
nodejs/docsto here (see linked PR: nodejs/docs#123):Following discussion in #11286 (comment), I think it makes more sense to have the style guide in the core repo.
I originally planned to put it in
doc/guides/, but on further thought I think it should be in the top leveldoc/repo, as it applies to everything. Happy to be disagreed with on that though.I think we should move it as is first, if any changes need to be made, we should make them in subsequent PRs.