doc: update AUTHORS list by targos · Pull Request #15181 · nodejs/node

targos · 2017-09-04T13:29:26Z

Update AUTHORS list using tools/update-authors.sh.

Checklist

documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

targos · 2017-09-04T13:31:45Z

There may be a few duplicates but this adds 282 new collaborators since the last update that was 4 months ago 🎉

lpinca · 2017-09-04T13:56:22Z

AUTHORS

lpinca · 2017-09-04T13:56:43Z

AUTHORS

lpinca · 2017-09-04T13:57:06Z

AUTHORS

TimothyGu · 2017-09-04T14:30:38Z

AUTHORS

Dup of 1504.

TimothyGu · 2017-09-04T14:34:02Z

AUTHORS

Maybe a dupe? @mhdawson can you confirm?

It's a dupe

TimothyGu · 2017-09-04T14:34:42Z

AUTHORS

TimothyGu · 2017-09-04T14:35:39Z

AUTHORS

TimothyGu · 2017-09-04T14:51:33Z

AUTHORS

TimothyGu · 2017-09-04T14:53:00Z

AUTHORS

Dupe of the line above.

TimothyGu · 2017-09-04T14:55:34Z

AUTHORS

Dupe of 1543

TimothyGu · 2017-09-04T14:57:28Z

AUTHORS

Dupe. Different email address though.

TimothyGu

LGTM with those fixed.

benjamingr · 2017-09-04T21:02:31Z

AUTHORS

@giltayar @MadaraUchiha

benjamingr · 2017-09-04T21:02:49Z

AUTHORS

benjamingr · 2017-09-04T21:03:54Z

AUTHORS

This is most likely a duplicate of [email protected] (work mail vs. old personal mail)

silverwind · 2017-09-04T21:21:10Z

Instead of removing duplicates, you should use .mailmap to alias them instead. That way, the next time this file is regenerated, you don't have to dedupe the same users again.

LakshmiSwethaG · 2017-09-05T07:21:09Z

@targos, thanks for this. I have since then changed my organization, and therefore the email IDs too. Can you please replace [email protected] with [email protected]?
thanks in advance."

targos · 2017-09-05T07:29:40Z

@silverwind do you know how it works? Because for example Ben keeps being added even though all his addresses are in the .mailmap

mhdawson

LGTM

silverwind · 2017-09-05T15:19:51Z

@targos I'm pretty sure that Ben's entry in .mailmap is invalid:

Ben Noordhuis <[email protected]> <bnoordhuis@bender.(none)> <[email protected]>

Acorrding to the shortlog docs, a mailmap entry can either contain a mail address or a mail address and a name after the "proper name and address", and certainly not three adresses so corrected, it should be:

Ben Noordhuis <[email protected]> <bnoordhuis@bender.(none)>
Ben Noordhuis <[email protected]> <[email protected]>

From a quick look, I think this is the only error in the current .mailmap.

targos · 2017-09-05T15:31:12Z

@silverwind Thank you, I understand now. Updating...

bidipyne · 2017-09-05T16:05:55Z

@targos, thanks a lot. Since then, I have changed my organization, and therefore email IDs too. Can you please replace my mail IDs [email protected] to [email protected]?
Thank You!

200GAUTAM · 2017-09-05T16:46:08Z

@targos, thanks a lot. Since then, I have changed my organization, and therefore email IDs too. Can you please replace my mail IDs [email protected] to [email protected]?
Thank You!

sreepurnajasti · 2017-09-06T05:20:20Z

AUTHORS

@targos As I have changed my organization, I would request you to update this with my personal email id: [email protected]. Thanks in advance.

sreepurnajasti · 2017-09-06T05:21:41Z

AUTHORS

@targos As I have changed my organization, I would request you to update this with my personal email id: [email protected].

Thanks in advance.

XadillaX

LGTM

targos · 2017-09-06T07:19:23Z

@LakshmiSwethaG, @bidipyne, @sreepurnajasti I changed your emails in the map.
@200GAUTAM I think it's already fine for you?

targos · 2017-09-06T07:22:36Z

@lpinca @TimothyGu @XadillaX @mhdawson @silverwind I made a significant change since last review. Now the mailmap is up to date and running tools/update-authors.sh creates the AUTHORS file as it is in my branch.

TimothyGu · 2017-09-06T09:20:30Z

.mailmap

Is this line needed?

It is, but I made a typo. It's a version of the name with lowercase "L". Weird that it was working with that mistake...

TimothyGu

mailmap is 🥇

200GAUTAM · 2017-09-06T11:21:48Z

@targos yes [email protected] was already there , Sorry for the confusion

targos · 2017-09-06T11:29:17Z

I searched for all remaining duplicate email addresses in AUTHORS and added them to the map

TimothyGu · 2017-09-06T12:51:58Z

AUTHORS

I assume the first one is a more formal name?

I chose the one that is on their GitHub profile: https://github.com/llkats

silverwind

Approach LGTM

Update AUTHORS list using tools/update-authors.sh.

targos · 2017-09-12T08:13:28Z

Landed in 3f7813b

Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: #15181 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: nodejs#15181 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Update AUTHORS list using tools/update-authors.sh. Update .mailmap to handle duplicates. PR-URL: #15181 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Khaidi Chu <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 4, 2017

lpinca reviewed Sep 4, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Member

lpinca Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup.

lpinca reviewed Sep 4, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Member

lpinca Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup.

lpinca reviewed Sep 4, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Member

lpinca Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dup.

lpinca approved these changes Sep 4, 2017

View reviewed changes

TimothyGu reviewed Sep 4, 2017

View reviewed changes

TimothyGu approved these changes Sep 4, 2017

View reviewed changes

benjamingr reviewed Sep 4, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Member

benjamingr Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@giltayar @MadaraUchiha

benjamingr reviewed Sep 4, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Member

benjamingr Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OriLev

benjamingr reviewed Sep 4, 2017

View reviewed changes

AUTHORS Outdated

Copy link

Member

benjamingr Sep 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is most likely a duplicate of [email protected] (work mail vs. old personal mail)

mhdawson approved these changes Sep 5, 2017

View reviewed changes

sreepurnajasti reviewed Sep 6, 2017

View reviewed changes

XadillaX approved these changes Sep 6, 2017

View reviewed changes

targos force-pushed the update-authors branch from d9c2a76 to 8a568b4 Compare September 6, 2017 07:18

gireeshpunathil approved these changes Sep 6, 2017

View reviewed changes

TimothyGu reviewed Sep 6, 2017

View reviewed changes

TimothyGu approved these changes Sep 6, 2017

View reviewed changes

benjamingr approved these changes Sep 6, 2017

View reviewed changes

TimothyGu reviewed Sep 6, 2017

View reviewed changes

silverwind approved these changes Sep 6, 2017

View reviewed changes

jasnell approved these changes Sep 6, 2017

View reviewed changes

doc: update AUTHORS list

cac0d58

Update AUTHORS list using tools/update-authors.sh.

targos force-pushed the update-authors branch from 45edee9 to cac0d58 Compare September 7, 2017 14:55

BridgeAR approved these changes Sep 9, 2017

View reviewed changes

targos closed this Sep 12, 2017

targos deleted the update-authors branch September 12, 2017 08:13

jasnell mentioned this pull request Sep 20, 2017

Node.js 8.6.0 Release Proposal #15509

Merged

MylesBorins added the land-on-v6.x label Oct 17, 2017

MylesBorins mentioned this pull request Oct 17, 2017

v6.12.0 proposal #16263

Merged

MylesBorins mentioned this pull request Nov 3, 2017

v4.8.6 proposal #16500

Merged

Uh oh!

Conversation

targos commented Sep 4, 2017

Checklist

Affected core subsystem(s)

Uh oh!

targos commented Sep 4, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TimothyGu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

silverwind commented Sep 4, 2017

Uh oh!

LakshmiSwethaG commented Sep 5, 2017

Uh oh!

targos commented Sep 5, 2017

Uh oh!

mhdawson left a comment

Choose a reason for hiding this comment

Uh oh!

silverwind commented Sep 5, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Sep 5, 2017

Uh oh!

bidipyne commented Sep 5, 2017

Uh oh!

200GAUTAM commented Sep 5, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

XadillaX left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Sep 6, 2017

Uh oh!

targos commented Sep 6, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TimothyGu left a comment

Choose a reason for hiding this comment

Uh oh!

200GAUTAM commented Sep 6, 2017

Uh oh!

targos commented Sep 6, 2017

silverwind commented Sep 5, 2017 •

edited

Loading