test:replace common.fixturesDir with commonfixtures#15832
Closed
feons wants to merge 3 commits intonodejs:masterfrom
Closed
test:replace common.fixturesDir with commonfixtures#15832feons wants to merge 3 commits intonodejs:masterfrom
feons wants to merge 3 commits intonodejs:masterfrom
Conversation
rmg
reviewed
Oct 6, 2017
Contributor
rmg
left a comment
rmg
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
| cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`), | ||
| key: fs.readFileSync(`${common.fixturesDir}/test_key.pem`) | ||
| cert: fs.readFileSync(fixtures.path('test_cert.pem')), | ||
| key: fs.readFileSync(fixtures.path('test_key.pem')) |
Contributor
There was a problem hiding this comment.
The fixtures module has a helper that make this even simpler! Check out fixtures.readSync().
That should let you do key: fixtures.readSync('test_key.pem') instead.
Trott
added
the
code-and-learn
Contributor
Author
|
@rmg, updated according to your comment. Thank you! |
tniessen
approved these changes
Oct 7, 2017
jasnell
approved these changes
Oct 9, 2017
cjihrig
approved these changes
Oct 10, 2017
gireeshpunathil
approved these changes
Oct 10, 2017
Member
gireeshpunathil
left a comment
gireeshpunathil
left a comment
There was a problem hiding this comment.
@feons - if you could remove the extra line at L34?
Member
Contributor
Author
|
@gireeshpunathil, fixed style. Thanks! |
BridgeAR
approved these changes
Oct 10, 2017
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15832 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Ruben Bridgewater <[email protected]>
Member
|
Landed in fc94eef |
gireeshpunathil
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15832 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
|
Corrected the commit message and re-landed in 03550a5 |
Member
|
Unfortunately, CI was never run on the subsequent changes (after the first CI) and this fails the linter. Is someone already on fast-tracking a fix for this? |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. Refs: nodejs#15832 (comment)
Member
|
Fix to minor issue in #16145 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Oct 11, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. PR-URL: nodejs#16145 Ref: nodejs#15832 (comment) Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15832 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. PR-URL: nodejs/node#16145 Ref: nodejs/node#15832 (comment) Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Member
|
@Trott - probably I overlooked at the CI. Thanks for addressing it! |
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #15832 Reviewed-By: Ryan Graham <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed. PR-URL: #16145 Ref: #15832 (comment) Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
common.fixturesDirwith usage of thecommon.fixturesmoduleChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)