test: use common.crashOnUnhandledRejection#17215
test: use common.crashOnUnhandledRejection#17215sj82516 wants to merge 1 commit intonodejs:masterfrom
Conversation
There was a problem hiding this comment.
I think common needs to be declared first:
const common = require('../common');
MylesBorins
added
the
code-and-learn
|
@sj82516 - your second commit brought about 94 files - accidental? |
|
I run |
|
It seems a bunch of pre-existing node modules are now being removed? |
mscdex
added
domain
|
yes, I removed them. |
jasnell
dismissed
their stale review
Removing my sign off until the extraneous commits can be cleaned up
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
This PR will need to be reworked to remove the extraneous edits
sj82516
force-pushed
the
my-first-pr-to-node
branch
from
1487903 to
449be86
Compare
|
I rebase the commit and push force again. |
|
Still the same problem. I think you will need to edit your commit since it seems the file removals are a part of the same commit as your actual (test) changes. |
reset the commit to remvoe extra instructions.
|
I see. |
|
@sj82516 you can always force push over the branch you made the PR with |
sj82516
force-pushed
the
my-first-pr-to-node
branch
from
449be86 to
d47c150
Compare
|
Looks better now. |
PR-URL: #17215 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
|
landed in 7518617 with some minor nits addressed |
PR-URL: #17215 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #17215 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #17215 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #17215 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
PR-URL: #17215 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
9 participants
Add common.crashOnUnhandledRejection to test/parallel/test-microtask-queue-integration-domain.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)