Closed
Conversation
nodejs-github-bot
added
doc
jasnell
approved these changes
Jan 9, 2018
Fishrock123
reviewed
Jan 9, 2018
doc/api/process.md
Outdated
Contributor
There was a problem hiding this comment.
Should we link to the supported platforms table? (I forget where it is..)
Contributor
Author
There was a problem hiding this comment.
I cannot find that either...
Member
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
@gibfahn it seems that the table just list the supported platforms, but not the value of the API.
gireeshpunathil
approved these changes
Jan 9, 2018
lpinca
approved these changes
Jan 10, 2018
Trott
reviewed
Jan 10, 2018
doc/api/process.md
Outdated
Member
There was a problem hiding this comment.
Non-blocking nit: Remove *Note*: and let the paragraph stand on its own.
Trott
reviewed
Jan 10, 2018
doc/api/process.md
Outdated
Member
There was a problem hiding this comment.
Nit: is considered to be experimental at this time -> is experimental.
Trott
reviewed
Jan 11, 2018
doc/api/process.md
Outdated
Member
There was a problem hiding this comment.
Non-blocking nit: remove "at this time"
Trott
approved these changes
Jan 11, 2018
gibfahn
reviewed
Jan 11, 2018
| ``` | ||
|
|
||
| The value `'android'` may also be returned if the Node.js is built on the | ||
| Android operating system. However, Android support in Node.js is experimental. |
Member
There was a problem hiding this comment.
@marswong , in reply to #18057 (comment)
Yes, I was replying to @Fishrock123 's suggestion that we link to the supported platforms table.
Maybe something like this:
Android support in Node.js is experimental.
tniessen
approved these changes
Jan 11, 2018
joyeecheung
added
the
author ready
Member
BridgeAR
approved these changes
Jan 19, 2018
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Jan 19, 2018
PR-URL: nodejs#18057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18057 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc