test: refactor test-async-wrap-getasyncid#18727
Closed
santigimeno wants to merge 1 commit intonodejs:masterfrom
Closed
test: refactor test-async-wrap-getasyncid#18727santigimeno wants to merge 1 commit intonodejs:masterfrom
santigimeno wants to merge 1 commit intonodejs:masterfrom
Conversation
Member
Author
Contributor
|
The problem with this test is unfortunately more than just I have a PR that proposes a potential solution: #18307 but I'm not entirely happy with it so I've marked it as |
Member
Author
|
@apapirovski thanks for the info. Would you be ok with the changes while keeping the test in |
Contributor
|
Yeah, I don't see why not. 👍 |
Member
|
yeah, this test definitely needs to stay in sequential. the other changes lgtm |
So it does not use `common.PORT` anymore.
santigimeno
force-pushed
the
async-wrap-getasyncid-to-parallel
branch
from
d18af51 to
a515ebc
Compare
Member
Author
|
Updated so it just removes the use of |
santigimeno
changed the title
BridgeAR
added
the
author ready
BridgeAR
approved these changes
Mar 2, 2018
apapirovski
approved these changes
Mar 4, 2018
Contributor
Contributor
|
Landed in a865e8b |
apapirovski
pushed a commit
that referenced
this pull request
Mar 4, 2018
So it does not use `common.PORT` anymore. PR-URL: #18727 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Mar 5, 2018
So it does not use `common.PORT` anymore. PR-URL: nodejs#18727 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
So it does not use `common.PORT` anymore. PR-URL: nodejs#18727 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
So it does not use `common.PORT` anymore. PR-URL: #18727 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By not using
common.PORTanymore.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test