(v8.x backport) crypto: reuse variable instead of reevaluation#19114
Closed
tniessen wants to merge 1 commit intonodejs:v8.x-stagingfrom
Closed
(v8.x backport) crypto: reuse variable instead of reevaluation#19114tniessen wants to merge 1 commit intonodejs:v8.x-stagingfrom
tniessen wants to merge 1 commit intonodejs:v8.x-stagingfrom
Conversation
PR-URL: nodejs#17735 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
nodejs-github-bot
added
c++
2 tasks
lpinca
approved these changes
Mar 4, 2018
gibfahn
approved these changes
Mar 4, 2018
Member
Contributor
|
potentially related failure in debian 8 https://ci.nodejs.org/job/node-test-commit-linux/17205/nodes=debian8-x86/console |
Member
Author
|
This PR should not affect TLS tests. I started two more CIs, the first failed |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
Backport-PR-URL: #19114 PR-URL: #17735 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Contributor
|
Thanks for the heads up landed in b43a59c |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
Backport-PR-URL: #19114 PR-URL: #17735 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
Backport-PR-URL: #19114 PR-URL: #17735 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #17735 to v8.x.