doc: remove subsystem from pull request template#19125
Closed
Trott wants to merge 1 commit intonodejs:masterfrom
Closed
doc: remove subsystem from pull request template#19125Trott wants to merge 1 commit intonodejs:masterfrom
Trott wants to merge 1 commit intonodejs:masterfrom
Conversation
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post.
Member
Author
lpinca
approved these changes
Mar 4, 2018
targos
approved these changes
Mar 4, 2018
apapirovski
approved these changes
Mar 4, 2018
tniessen
approved these changes
Mar 4, 2018
Member
tniessen
left a comment
There was a problem hiding this comment.
Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post.
Same here.
benjamingr
approved these changes
Mar 4, 2018
gibfahn
approved these changes
Mar 4, 2018
devsnek
approved these changes
Mar 4, 2018
BridgeAR
approved these changes
Mar 4, 2018
cjihrig
approved these changes
Mar 4, 2018
mmarchini
approved these changes
Mar 5, 2018
TimothyGu
approved these changes
Mar 5, 2018
jasnell
approved these changes
Mar 5, 2018
maclover7
approved these changes
Mar 6, 2018
kfarnung
approved these changes
Mar 6, 2018
Contributor
|
Landed in c72e540 🎉 |
apapirovski
pushed a commit
that referenced
this pull request
Mar 6, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 6, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
Hackzzila
added a commit
to Hackzzila/node
that referenced
this pull request
Apr 25, 2018
2 tasks
tniessen
pushed a commit
that referenced
this pull request
Apr 25, 2018
PR-URL: #20277 Refs: #19125 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
May 4, 2018
PR-URL: #20277 Refs: #19125 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: nodejs#19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: nodejs#19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. Backport-PR-URL: #22380 PR-URL: #19125 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Kyle Farnung <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove request that user provide a list of subsystems in the pull
request template.
commit message.
do a rather good job. Tools over rules. Let the bot do it.
barrier to entry.
submitting the PR list out subsystems in the pull request post.
Checklist
Affected core subsystem(s)
doc