[v6.x backport] win, build: fix intl-none and without-intl options#19485
Closed
poiru wants to merge 2 commits intonodejs:v6.x-stagingfrom
poiru:backport-17614-18292-to-v6.x
Closed
[v6.x backport] win, build: fix intl-none and without-intl options#19485poiru wants to merge 2 commits intonodejs:v6.x-stagingfrom poiru:backport-17614-18292-to-v6.x
poiru wants to merge 2 commits intonodejs:v6.x-stagingfrom
poiru:backport-17614-18292-to-v6.x
Conversation
Fixes --with-intl option passed to configure script when without-intl is used PR-URL: #17614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Like #17614, but for the `intl-none` option. Refs: #17614 PR-URL: #18292 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
nodejs-github-bot
added
build
Contributor
bzoz
approved these changes
Mar 21, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
Fixes --with-intl option passed to configure script when without-intl is used Backport-PR-URL: #19485 PR-URL: #17614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 21, 2018
Like #17614, but for the `intl-none` option. Backport-PR-URL: #19485 Refs: #17614 PR-URL: #18292 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
Contributor
|
landed in fe477e4...331b4fd |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
Fixes --with-intl option passed to configure script when without-intl is used Backport-PR-URL: #19485 PR-URL: #17614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2018
Like #17614, but for the `intl-none` option. Backport-PR-URL: #19485 Refs: #17614 PR-URL: #18292 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
Fixes --with-intl option passed to configure script when without-intl is used Backport-PR-URL: #19485 PR-URL: #17614 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 30, 2018
Like #17614, but for the `intl-none` option. Backport-PR-URL: #19485 Refs: #17614 PR-URL: #18292 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Bartosz Sosnowski <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports #17614 and #18292.
Checklist
vcbuild test