tools,doc: update authors script + list by addaleax · Pull Request #22771 · nodejs/node

addaleax · 2018-09-09T11:14:30Z

Now with built-in support for co-authored commits! :)

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
documentation is changed or added
commit message follows commit guidelines

Replace the previous Perl script with a Node.js variant that explicitly supports `Author:` and, in particular, GitHub’s standard `Co-authored-by:` metadata tags.

This includes some re-ordering due to the newly added support for co-authored commits.

nodejs-github-bot · 2018-09-09T11:14:40Z

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/839/pipeline

addaleax · 2018-09-09T11:14:52Z

.mailmap

 Juan Sebastian Velez Posada <[email protected]>
 Kai Sasaki Lewuathe <[email protected]>
 Karl Skomski <[email protected]> <[email protected]>
+Kat Marchán <[email protected]> <[email protected]>


@zkat Can you confirm that this is your preferred email now? :)

.mailmap

tools/update-authors.js

targos · 2018-09-09T11:28:43Z

tools/update-authors.js

+  const match = line.match(authorRe);
+  if (!match) return;
+
+  const [ _, author, email ] = match;  // eslint-disable-line no-unused-vars


It could have been interesting to try named capture groups (just a suggestion, of course)

Interesting, I didn’t know they were available – done!

They're in ES2018 :)

BridgeAR · 2018-09-10T05:21:16Z

AUTHORS

+Joonas Rouhiainen <[email protected]>
+GauthamBanasandra <[email protected]>
+Hugo Josefson <[email protected]>
+Weijia Wang <[email protected]>


I guess there is an earlier entry as well?

Thanks, yes. @starkwang Can you confirm that the qq.com address is your preferred one?

mcollina

LGTM

jasnell

Rubberstamp LGTM

addaleax · 2018-09-12T11:03:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17134/

addaleax · 2018-09-14T17:02:02Z

Landed in 175a88f, 48e8918

Replace the previous Perl script with a Node.js variant that explicitly supports `Author:` and, in particular, GitHub’s standard `Co-authored-by:` metadata tags. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

This includes some re-ordering due to the newly added support for co-authored commits. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replace the previous Perl script with a Node.js variant that explicitly supports `Author:` and, in particular, GitHub’s standard `Co-authored-by:` metadata tags. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

This includes some re-ordering due to the newly added support for co-authored commits. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replace the previous Perl script with a Node.js variant that explicitly supports `Author:` and, in particular, GitHub’s standard `Co-authored-by:` metadata tags. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

This includes some re-ordering due to the newly added support for co-authored commits. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

Replace the previous Perl script with a Node.js variant that explicitly supports `Author:` and, in particular, GitHub’s standard `Co-authored-by:` metadata tags. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

This includes some re-ordering due to the newly added support for co-authored commits. PR-URL: #22771 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>

addaleax added 2 commits September 9, 2018 13:14

tools: implement update-authors in JS

6ca7e39

Replace the previous Perl script with a Node.js variant that explicitly supports `Author:` and, in particular, GitHub’s standard `Co-authored-by:` metadata tags.

doc: update AUTHORS list

0d3ad1d

This includes some re-ordering due to the newly added support for co-authored commits.

addaleax requested a review from targos September 9, 2018 11:14

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Sep 9, 2018

addaleax commented Sep 9, 2018

View reviewed changes

targos approved these changes Sep 9, 2018

View reviewed changes

fixup! tools: implement update-authors in JS

800c938

danbev approved these changes Sep 9, 2018

View reviewed changes

tniessen approved these changes Sep 9, 2018

View reviewed changes

addaleax mentioned this pull request Sep 9, 2018

node-report: meld into core #22712

Merged

4 tasks

lpinca approved these changes Sep 9, 2018

View reviewed changes

sagirk approved these changes Sep 9, 2018

View reviewed changes

mmarchini approved these changes Sep 9, 2018

View reviewed changes

richardlau approved these changes Sep 9, 2018

View reviewed changes

BridgeAR approved these changes Sep 10, 2018

View reviewed changes

mcollina approved these changes Sep 10, 2018

View reviewed changes

jasnell approved these changes Sep 10, 2018

View reviewed changes

fixup! doc: update AUTHORS list

c7d7249

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 12, 2018

addaleax closed this Sep 14, 2018

addaleax deleted the update-authors branch September 14, 2018 17:02

targos mentioned this pull request Sep 18, 2018

Release proposal: v10.11.0 #22932

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools,doc: update authors script + list#22771

tools,doc: update authors script + list#22771
addaleax wants to merge 4 commits intonodejs:masterfrom
addaleax:update-authors

addaleax commented Sep 9, 2018

Uh oh!

nodejs-github-bot commented Sep 9, 2018

Uh oh!

addaleax Sep 9, 2018

Uh oh!

Uh oh!

Uh oh!

targos Sep 9, 2018

Uh oh!

addaleax Sep 9, 2018

Uh oh!

targos Sep 9, 2018

Uh oh!

BridgeAR Sep 10, 2018

Uh oh!

addaleax Sep 11, 2018

Uh oh!

mcollina left a comment

Uh oh!

jasnell left a comment

Uh oh!

addaleax commented Sep 12, 2018

Uh oh!

addaleax commented Sep 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

addaleax commented Sep 9, 2018

Checklist

Uh oh!

nodejs-github-bot commented Sep 9, 2018

Uh oh!

addaleax Sep 9, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

targos Sep 9, 2018

Choose a reason for hiding this comment

Uh oh!

addaleax Sep 9, 2018

Choose a reason for hiding this comment

Uh oh!

targos Sep 9, 2018

Choose a reason for hiding this comment

Uh oh!

BridgeAR Sep 10, 2018

Choose a reason for hiding this comment

Uh oh!

addaleax Sep 11, 2018

Choose a reason for hiding this comment

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

addaleax commented Sep 12, 2018

Uh oh!

addaleax commented Sep 14, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants