util: extract uncurryThis function for reuse#23081
util: extract uncurryThis function for reuse#23081ZYSzys wants to merge 2 commits intonodejs:masterfrom zys-contrib:extract-util
uncurryThis function for reuse#23081Conversation
nodejs-github-bot
added
the
lib / src
lundibundi
left a comment
lundibundi
left a comment
There was a problem hiding this comment.
LGTM. Though I'm +1 for @Fishrock123 suggestion of moving this to util.js.
|
Now I'm torn between keeping it in Hey guys, which one should I choose ? 😬 |
|
I'm not sure I'm very pro deduplicating code, so to me |
|
We already use functions from |
Sounds like a good compromise. Maybe add a |
|
It was changed now. How should I fixed it ? |
|
@ZYSzys don't worry, that's a known bug, it'll be fixed soon. |
|
@Fishrock123 @lundibundi PTAL |
|
ping @Fishrock123 Sorry for bothering you. It has almost been three months, and I've moved the |
ZYSzys
changed the title
uncurryThis functionuncurryThis function for reuse
ZYSzys
added
the
author ready
PR-URL: nodejs#23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: nodejs#23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
PR-URL: #23081 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: John-David Dalton <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
13 participants
Extracts
uncurryThisfunction which is done in identical ways in a few places inlib/internal/utildir.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes