[10.x] vm: add dynamic import support#25421
[10.x] vm: add dynamic import support#25421joyeecheung wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
PR-URL: nodejs#22381 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
nodejs-github-bot
added
lib / src
|
cc @devsnek |
|
cc @targos I believe this is semver-minor? |
|
I would suggest holding off on this while #25424 remains a concern. |
|
@guybedford I am fine with that, but be aware this unblocks clean cherry-pick of other refactoring patches to the bootstrap process |
|
@joyeecheung I understand. As it is an experimental API we could go ahead with the merge despite the bug if it would help follow-on PR work, we just need to continue to note that the |
|
Personally I think we should change the API to tie the dynamic import callback to the context. |
|
@joyeecheung assuming #21573 lands now, we should probably stick with backporting this to continue to enable backports despite the experimental woes mentioned. |
MylesBorins
force-pushed
the
v10.x-staging
branch
from
c1ee936 to
c6cffad
Compare
codebytere
force-pushed
the
v10.x-staging
branch
3 times, most recently
from
2d6e145 to
7840f71
Compare
|
Landed on |
Backport-PR-URL: #25421 PR-URL: #22381 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
Backport-PR-URL: #25421 PR-URL: #22381 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Tiancheng "Timothy" Gu <[email protected]>
6 participants
PR-URL: #22381
Reviewed-By: James M Snell [email protected]
Reviewed-By: Guy Bedford [email protected]
Reviewed-By: Tiancheng "Timothy" Gu [email protected]