inspector: display error when ToggleAsyncHook fails by joyeecheung · Pull Request #26859 · nodejs/node

joyeecheung · 2019-03-22T16:10:11Z

This patch refactors AppendExceptionLine and PrintSyncTrace
to reuse the error formatting logic and use them to print
uncaught error in ``ToggleAsyncHook`

Refs: #26798

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2019-03-22T16:10:13Z

@joyeecheung build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/3009/pipeline

joyeecheung · 2019-03-22T16:12:10Z

Stress test: https://ci.nodejs.org/job/node-stress-single-test/2178/

joyeecheung · 2019-03-22T16:43:13Z

00:28:08     [err] async_hooks.js:32
00:28:08     [err]   async_id_symbol, trigger_async_id_symbol,
00:28:08     [err]   ^
00:28:08     [err] 
00:28:08     [err] TypeError: Cannot destructure property `async_id_symbol` of 'undefined' or 'null'.
00:28:08     [err]     at async_hooks.js:31:7
00:28:08     [err]     at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
00:28:08     [err]     at nativeModuleRequire (internal/bootstrap/loaders.js:188:14)
00:28:08     [err]     at lazyHookCreation (internal/inspector_async_hook.js:8:26)
00:28:08     [err]     at enable (internal/inspector_async_hook.js:47:27)
00:28:08     [err]     at internal/async_hooks.js:1:1
00:28:08     [err]     at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
00:28:08     [err]     at nativeModuleRequire (internal/bootstrap/loaders.js:188:14)
00:28:08     [err]     at internal/process/task_queues.js:31:5
00:28:08     [err]     at NativeModule.compile (internal/bootstrap/loaders.js:300:5)
00:28:08     [err]     at nativeModuleRequire (internal/bootstrap/loaders.js:188:14)

From the CI

joyeecheung · 2019-03-22T16:43:50Z

Looks like it's yet another circular dependency issue

joyeecheung · 2019-03-22T16:52:51Z

Try to see more traces by setting Error.stackTraceLimit = Infinity; https://ci.nodejs.org/job/node-stress-single-test/2182

joyeecheung · 2019-03-22T17:18:37Z

er, this is interesting, setting Error.stackTraceLimit = Infinity results in 100% failure with a new one filling the rest of the cases

EDIT: oh, I was being silly, the line number changed.

joyeecheung · 2019-03-22T17:22:17Z

stress test: https://ci.nodejs.org/job/node-stress-single-test/2183/

joyeecheung · 2019-03-22T17:34:54Z

Looks like it's too late to set Error.stackTraceLimit = Infinity in user code. Trying another approach..

https://ci.nodejs.org/job/node-stress-single-test/2184/

joyeecheung · 2019-03-22T19:12:57Z

Let's see if moving setupHooks makes a difference (if not, then setupHooks is not the key here). https://ci.nodejs.org/job/node-stress-single-test/2192/

joyeecheung · 2019-03-22T19:27:57Z

setupHooks is not the key here. Or maybe it needs to enter the context first..https://ci.nodejs.org/job/node-stress-single-test/2193/

Otherwise the exports of `internal/async_hooks` may be undefined when the inspector async hooks are registered. PR-URL: nodejs#26866 Fixes: nodejs#26798 Refs: nodejs#26859 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

This patch refactors `AppendExceptionLine` and `PrintSyncTrace` to reuse the error formatting logic and use them to print uncaught error in ``ToggleAsyncHook`

nodejs-github-bot · 2019-03-26T19:27:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21935/

joyeecheung · 2019-03-26T19:30:23Z

cc @nodejs/v8-inspector @nodejs/async_hooks

Removed the investigation code and made it a patch that prints more information when ToggleAsyncHook fails. I'd like to land this to investigate #26798 further.

(We could probably reuse PrintCaughtException through out the code base to print more stuff before hard crash on JS errors)

mcollina · 2019-03-27T11:01:53Z

@joyeecheung does this change functionality? display error when ToggleAsyncHook fails seems it adds a new feature, but I don't see any tests added.

mcollina · 2019-03-27T11:03:08Z

@joyeecheung does this change functionality? display error when ToggleAsyncHook fails seems it adds a new feature, but I don't see any tests added. It also seems a refactoring and not a change in functionality, so maybe the commit message is not correct.

Code looks ok to me.

joyeecheung · 2019-03-27T11:57:06Z

@mcollina No, the error only shows up when there is a bug (see the referenced flaky test), and it will crash the process immediately, this just prints more information to stderr before crashing to facilitate debugging. I don’t think tests can be added (the internals affected are not even monkey patchable since it’s done before any user code execution)

ToggleAsyncHook is an internal C++ function, not accessible in the user land so I don’t think the message implies it changes functionality?

mcollina

LGTM

Otherwise the exports of `internal/async_hooks` may be undefined when the inspector async hooks are registered. PR-URL: nodejs#26866 Fixes: nodejs#26798 Refs: nodejs#26859 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

Otherwise the exports of `internal/async_hooks` may be undefined when the inspector async hooks are registered. PR-URL: #26866 Fixes: #26798 Refs: #26859 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>

joyeecheung · 2019-03-30T04:42:16Z

Landed in 61ef9df

This patch refactors `AppendExceptionLine` and `PrintSyncTrace` to reuse the error formatting logic and use them to print uncaught error in ``ToggleAsyncHook` PR-URL: #26859 Refs: #26798 Reviewed-By: Matteo Collina <[email protected]>

This patch refactors `AppendExceptionLine` and `PrintSyncTrace` to reuse the error formatting logic and use them to print uncaught error in ``ToggleAsyncHook` PR-URL: #26859 Refs: #26798 Reviewed-By: Matteo Collina <[email protected]> Signed-off-by: Beth Griggs <[email protected]>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 22, 2019

joyeecheung mentioned this pull request Mar 22, 2019

investigate flaky test-inspect-async-hook-setup-at-inspect on Windows 2008r2 in CI #26798

Closed

joyeecheung force-pushed the display-message branch from 4a0d069 to eeee2ed Compare March 22, 2019 17:33

joyeecheung mentioned this pull request Mar 22, 2019

process: load internal/async_hooks before inspector hooks registration #26866

Merged

2 tasks

joyeecheung force-pushed the display-message branch from eeee2ed to cede98c Compare March 22, 2019 19:12

BridgeAR added the wip Issues and PRs that are still a work in progress. label Mar 25, 2019

joyeecheung force-pushed the display-message branch 3 times, most recently from fd8dc54 to 1fcb78c Compare March 26, 2019 19:23

inspector: display error when ToggleAsyncHook fails

370c231

This patch refactors `AppendExceptionLine` and `PrintSyncTrace` to reuse the error formatting logic and use them to print uncaught error in ``ToggleAsyncHook`

joyeecheung force-pushed the display-message branch from 1fcb78c to 370c231 Compare March 26, 2019 19:25

joyeecheung removed the wip Issues and PRs that are still a work in progress. label Mar 26, 2019

BridgeAR requested review from AndreasMadsen, eugeneo and mcollina March 27, 2019 10:54

mcollina approved these changes Mar 27, 2019

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 27, 2019

joyeecheung closed this Mar 30, 2019

joyeecheung mentioned this pull request Mar 31, 2019

lib: throw a special error in internal/assert #26635

Closed

2 tasks

BethGriggs mentioned this pull request Apr 9, 2019

v11.14.0 proposal #27163

Merged

Uh oh!

Conversation

joyeecheung commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

nodejs-github-bot commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Mar 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

joyeecheung commented Mar 22, 2019

Uh oh!

nodejs-github-bot commented Mar 26, 2019

Uh oh!

joyeecheung commented Mar 26, 2019

Uh oh!

mcollina commented Mar 27, 2019

Uh oh!

mcollina commented Mar 27, 2019

Uh oh!

joyeecheung commented Mar 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

joyeecheung commented Mar 30, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

joyeecheung commented Mar 22, 2019 •

edited

Loading

joyeecheung commented Mar 22, 2019 •

edited

Loading

joyeecheung commented Mar 22, 2019 •

edited

Loading

joyeecheung commented Mar 27, 2019 •

edited

Loading