Closed
Conversation
Collaborator
jasnell
approved these changes
May 8, 2019
targos
approved these changes
May 8, 2019
gireeshpunathil
approved these changes
May 8, 2019
Trott
approved these changes
May 8, 2019
Member
|
Onboarding checklist for after this lands: https://github.com/nodejs/TSC/blob/master/ONBOARDING.md#onboarding |
richardlau
approved these changes
May 8, 2019
cjihrig
approved these changes
May 8, 2019
apapirovski
approved these changes
May 8, 2019
Contributor
|
Thanks, you all. @rvaggg "Voted on async in the TSC repo. This adds him to the TSC list in the README." failed the linter, I think it needs to be wrapped? I looked at the onboarding, and I confirm I've read, agree to, and support the https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md. |
Voted on async in the TSC repo. This adds him to the TSC list in the README. Fixes: nodejs/TSC#687
fhinkel
approved these changes
May 9, 2019
danbev
approved these changes
May 9, 2019
rvagg
added a commit
to nodejs/email
that referenced
this pull request
May 9, 2019
rvagg
added a commit
to nodejs/create-node-meeting-artifacts
that referenced
this pull request
May 9, 2019
rvagg
added a commit
that referenced
this pull request
May 9, 2019
Voted on async in the TSC repo. This adds him to the TSC list in the README. Fixes: nodejs/TSC#687 PR-URL: #27606 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Member
Author
|
I'm taking the approval and 3 week waiting period that happened in nodejs/TSC#687 and the many signoffs here as good enough to land here without a full 48 hours. I hope that's not inappropriate! Landed in e582d11 |
rvagg
added a commit
to nodejs/email
that referenced
this pull request
May 9, 2019
Ref: nodejs/node#27606 Ref: nodejs/TSC#687 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
Member
Seems like the fast-track label and process would have been appropriate. (Retroactive +1 from me for fast-tracking.) |
mhdawson
pushed a commit
to nodejs/create-node-meeting-artifacts
that referenced
this pull request
May 9, 2019
PR-URL: #61 Refs: nodejs/node#27606 Refs: nodejs/TSC#687 Reviewed-By: Michael Dawson <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 9, 2019
Voted on async in the TSC repo. This adds him to the TSC list in the README. Fixes: nodejs/TSC#687 PR-URL: #27606 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
uneoka0114
pushed a commit
to uneoka0114/NodeJS-Email
that referenced
this pull request
Jul 16, 2024
Ref: nodejs/node#27606 Ref: nodejs/TSC#687 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Voted on async in the TSC repo. This adds him to the TSC list in the README.
Fixes: nodejs/TSC#687