[v12.x] Backport update to V8 7.7#29241
Closed
targos wants to merge 21 commits intonodejs:v12.x-stagingfrom
Closed
[v12.x] Backport update to V8 7.7#29241targos wants to merge 21 commits intonodejs:v12.x-stagingfrom
targos wants to merge 21 commits intonodejs:v12.x-stagingfrom
Conversation
nodejs-github-bot
added
build
targos
added
the
semver-minor
Collaborator
Collaborator
Collaborator
Member
|
I think we need to undo the public parts of v8/v8@e423f00, too. |
Member
Author
|
I was not sur because I saw that the old methods are deprecated and not removed, but I'll check that everything is still here |
Member
Author
|
@addaleax I checked, and all |
Member
|
@targos Yes, but the layout of the fields changed, affecting the class’s size and the way that the inline getters/setters access the fields. And from the research on Workers I know that there are native modules that create new |
Member
Author
|
I see. Could you help me a bit on the compatibility patch? I don't really know what to do. |
Contributor
Collaborator
Member
|
Pushed changes to hopefully take care of V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2486/ |
Collaborator
Member
|
In v8-inspector.h, the addition of |
Member
Author
|
@bnoordhuis the |
Merged
Contributor
|
Does this backport includes fix from? -> #29472 🤔 |
PR-URL: nodejs#28016 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jiawen Geng <[email protected]>
Original commit message:
[testrunner] delete ancient junit compatible format support
Testrunner has ancient support for JUnit compatible XML output.
This CL removes this old feature.
[email protected],[email protected],[email protected]
CC=[email protected]
Bug: v8:8728
Change-Id: I7e1beb011dbaec3aa1a27398a5c52abdd778eaf0
Reviewed-on: https://chromium-review.googlesource.com/c/1430065
Reviewed-by: Jakob Gruber <[email protected]>
Reviewed-by: Michael Starzinger <[email protected]>
Commit-Queue: Tamer Tas <[email protected]>
Cr-Commit-Position: refs/heads/master@{nodejs#59045}
Refs: v8/v8@bd019bd
PR-URL: nodejs#26685
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
PR-URL: nodejs#26685 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
Update postmortem metadata constants for V8 7.7 in Node.js. PR-URL: nodejs#28918 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
added a commit
that referenced
this pull request
Oct 8, 2019
Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos
added a commit
that referenced
this pull request
Oct 8, 2019
Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #29241 PR-URL: #28955
targos
added a commit
that referenced
this pull request
Oct 8, 2019
Co-authored-by: Anna Henningsen <[email protected]> PR-URL: #29241 Reviewed-By: Ben Noordhuis <[email protected]>
targos
added a commit
to targos/node
that referenced
this pull request
Oct 25, 2019
Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: nodejs#29241 Backport-PR-URL: nodejs#28955 PR-URL: nodejs#28005 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
targos
added a commit
to targos/node
that referenced
this pull request
Oct 25, 2019
Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#29241 PR-URL: nodejs#28955
targos
added a commit
to targos/node
that referenced
this pull request
Oct 25, 2019
Co-authored-by: Anna Henningsen <[email protected]> PR-URL: nodejs#29241 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
to targos/node
that referenced
this pull request
Jan 7, 2020
Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: nodejs#29241 Backport-PR-URL: nodejs#28955 PR-URL: nodejs#28005 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
MylesBorins
pushed a commit
to targos/node
that referenced
this pull request
Jan 7, 2020
Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: nodejs#29241 PR-URL: nodejs#28955
MylesBorins
pushed a commit
to targos/node
that referenced
this pull request
Jan 7, 2020
Co-authored-by: Anna Henningsen <[email protected]> PR-URL: nodejs#29241 Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2020
Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #30109 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2020
Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 Backport-PR-URL: #29241 PR-URL: #28955
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2020
Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Reverts v8/v8@1b51dca Reverts v8/v8@1ab717d Partially reverts v8/v8@b0077b3 Backport-PR-URL: #30109 Backport-PR-URL: #29241 Backport-PR-URL: #28955 PR-URL: #28005 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Reverts v8/v8@4214933. Reverts v8/v8@c76f377. Reverts v8/v8@e0d7f81. Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 Backport-PR-URL: #29241 PR-URL: #28955
BethGriggs
pushed a commit
that referenced
this pull request
Feb 6, 2020
Co-authored-by: Anna Henningsen <[email protected]> Backport-PR-URL: #30109 PR-URL: #29241 Reviewed-By: Ben Noordhuis <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shouldn't land before V8 7.7 is stable (around September 10th).
/cc @nodejs/v8-update @addaleax
Here's the current headers diff: https://gist.github.com/ee79b943316ea502a538145531f76dfa