Skip to content

Update CHANGELOG_V12.md#29716

Closed
XhmikosR wants to merge 1 commit intonodejs:masterfrom
XhmikosR:patch-1
Closed

Update CHANGELOG_V12.md#29716
XhmikosR wants to merge 1 commit intonodejs:masterfrom
XhmikosR:patch-1

Conversation

@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Sep 26, 2019

Remove redundant escape

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 26, 2019
@richardlau
Copy link
Member

richardlau commented Sep 26, 2019

I believe the changelogs are partially generated by https://github.com/nodejs/changelog-maker (cc @nodejs/releasers) and the escaping is done in https://github.com/nodejs/changelog-maker/blob/867cf90110b3539d33f503360df1a94840bfd868/commit-to-output.js#L5-L8 so this will keep happening unless the tooling is updated.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 26, 2019

Upstream issue nodejs/changelog-maker#58

I think we should get this fixed there before merging this because it'll just keep happening.

@Trott
Copy link
Member

Trott commented Sep 27, 2019

LIte CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3935/

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 27, 2019
@Trott
Copy link
Member

Trott commented Sep 27, 2019

It's not really blocked by the upstream change, but I labeled it blocked anyway so that we don't land it until it's fixed upstream. If someone thinks we should just land this fix anyway, feel free to clear the blocked label and land it. I don't have a problem waiting or not waiting. Just labeling in accord with conversation above thus far.

@XhmikosR
Copy link
Contributor Author

XhmikosR commented Sep 29, 2019 •
edited
Loading

I haven't forgotten about this. I've just made a few PRs upstream and I try to make this work cross-platform before I get to the point to play with the regex, which is quite tricky by itself.

Any help welcome.

@Trott Trott removed the blocked PRs that are blocked by other issues or PRs. label Oct 1, 2019
@Trott
Copy link
Member

Trott commented Oct 1, 2019

Landed in a8956e4

@Trott Trott closed this Oct 1, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 1, 2019
@XhmikosR @Trott
doc: remove redundant escape
a8956e4 
PR-URL: nodejs#29716
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@XhmikosR XhmikosR deleted the patch-1 branch October 1, 2019 16:45
BridgeAR pushed a commit that referenced this pull request Oct 9, 2019
@XhmikosR @BridgeAR
doc: remove redundant escape
f39259c 
PR-URL: #29716
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Oct 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@XhmikosR @richardlau @Trott @BridgeAR @trivikr @nodejs-github-bot