[v12.x] ESM Module update by MylesBorins · Pull Request #32610 · nodejs/node

MylesBorins · 2020-04-02T05:00:33Z

outstanding module backports.

Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by: Rich Trott <[email protected]> PR-URL: nodejs#32274 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>

nodejs-github-bot · 2020-04-02T05:04:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30362/

MylesBorins · 2020-04-02T06:07:53Z

@addaleax lots of parallel/test-http2-reset-flood timeout failures on this PR. Thoughts about what is going on?

edit: your fix has already landed fwiw

nodejs-github-bot · 2020-04-02T06:09:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30364/

GeoffreyBooth

Assuming this is just adding to 12 what's already merged into master/13, RSLGTM. I think the only thing we need to check, probably manually, is that the flags on 12 behave as we expect them to on 12 (i.e. I think --experimental-modules is still required on 12, so this PR shouldn't accidentally remove that).

MylesBorins · 2020-04-02T19:58:35Z

@GeoffreyBooth good catch I think that aef34fd should resolve that concern (pun intended). AFAICT import.meta.resolve is the only change that introduced anything new. @guybedford could you confirm

PR-URL: nodejs#31032 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]>

PR-URL: nodejs#31625 Reviewed-By: Jan Krems <[email protected]>

PR-URL: nodejs#32147 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

PR-URL: nodejs#32068 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

PR-URL: nodejs#31479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Simplify complex sentence. Remove use of "straightforward". PR-URL: nodejs#32427 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#32462 Refs: nodejs#31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. PR-URL: nodejs#32457 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>

This matches what the lint-js make target passes through the CLI. PR-URL: nodejs#32145 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Co-Authored-By: Geoffrey Booth <[email protected]> PR-URL: nodejs#32098 Reviewed-By: Geoffrey Booth <[email protected]>

nodejs-github-bot · 2020-04-03T08:09:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30413/

MylesBorins · 2020-04-03T14:59:33Z

@addaleax check out the last CI run where we had yet another flake with http2 flood. Thoughts?

nodejs-github-bot · 2020-04-03T15:20:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30420/

nodejs-github-bot · 2020-04-03T16:44:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/30423/

Backport-PR-URL: #32610 PR-URL: #31032 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Backport-PR-URL: #32610 PR-URL: #31625 Reviewed-By: Jan Krems <[email protected]>

Backport-PR-URL: #32610 PR-URL: #32147 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Backport-PR-URL: #32610 PR-URL: #32068 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

Backport-PR-URL: #32610 PR-URL: #31479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Myles Borins <[email protected]>

Simplify complex sentence. Remove use of "straightforward". Backport-PR-URL: #32610 PR-URL: #32427 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Signed-off-by: Richard Lau <[email protected]> Backport-PR-URL: #32610 PR-URL: #32462 Refs: #31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. Backport-PR-URL: #32610 PR-URL: #32457 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Myles Borins <[email protected]>

This matches what the lint-js make target passes through the CLI. Backport-PR-URL: #32610 PR-URL: #32145 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Backport-PR-URL: #32610 Co-Authored-By: Geoffrey Booth <[email protected]> PR-URL: #32098 Reviewed-By: Geoffrey Booth <[email protected]>

PR-URL: #32610 Reviewed-By: Geoffrey Booth <[email protected]>

MylesBorins · 2020-04-03T19:57:57Z

landed in c0e6e60...e88960d

MylesBorins requested review from GeoffreyBooth and guybedford April 2, 2020 05:00

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. v12.x labels Apr 2, 2020

MylesBorins force-pushed the 12.x-module-update branch 2 times, most recently from 93c6c3f to 36c911a Compare April 2, 2020 05:03

nodejs deleted a comment from nodejs-github-bot Apr 2, 2020

GeoffreyBooth approved these changes Apr 2, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

guybedford and others added 11 commits April 3, 2020 04:09

esm: import.meta.resolve with nodejs: builtins

a1a282f

PR-URL: nodejs#31032 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]>

module: package "exports" error refinements

37aee30

PR-URL: nodejs#31625 Reviewed-By: Jan Krems <[email protected]>

esm: remove unused parameter on module.instantiate

e147f61

PR-URL: nodejs#32147 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

module: add hook for global preload code

07b77a3

PR-URL: nodejs#32068 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

doc: import clarifications with links to MDN

9da5813

PR-URL: nodejs#31479 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Myles Borins <[email protected]>

doc: fix lint warning in doc/api/esm.md

5c7c915

Signed-off-by: Richard Lau <[email protected]> PR-URL: nodejs#32462 Refs: nodejs#31479 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

doc: update conditional exports recommendations

4ab422a

Co-Authored-By: Geoffrey Booth <[email protected]> PR-URL: nodejs#32098 Reviewed-By: Geoffrey Booth <[email protected]>

doc: esm spec bug

fce87a5

MylesBorins force-pushed the 12.x-module-update branch from 34bc525 to fce87a5 Compare April 3, 2020 08:09

MylesBorins pushed a commit that referenced this pull request Apr 3, 2020

esm: import.meta.resolve with nodejs: builtins

05091d4

Backport-PR-URL: #32610 PR-URL: #31032 Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Myles Borins <[email protected]>

MylesBorins pushed a commit that referenced this pull request Apr 3, 2020

module: package "exports" error refinements

c537afb

Backport-PR-URL: #32610 PR-URL: #31625 Reviewed-By: Jan Krems <[email protected]>

MylesBorins pushed a commit that referenced this pull request Apr 3, 2020

module: add hook for global preload code

62b5bd4

Backport-PR-URL: #32610 PR-URL: #32068 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]>

MylesBorins pushed a commit that referenced this pull request Apr 3, 2020

doc: update conditional exports recommendations

155a6c3

Backport-PR-URL: #32610 Co-Authored-By: Geoffrey Booth <[email protected]> PR-URL: #32098 Reviewed-By: Geoffrey Booth <[email protected]>

MylesBorins added a commit that referenced this pull request Apr 3, 2020

doc: esm spec bug

e88960d

PR-URL: #32610 Reviewed-By: Geoffrey Booth <[email protected]>

MylesBorins closed this Apr 3, 2020

codebytere mentioned this pull request Apr 4, 2020

v12.16.2 proposal #32313

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[v12.x] ESM Module update#32610

[v12.x] ESM Module update#32610
MylesBorins wants to merge 12 commits intonodejs:v12.x-stagingfrom
MylesBorins:12.x-module-update

MylesBorins commented Apr 2, 2020

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

MylesBorins commented Apr 2, 2020 •

edited

Loading

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

GeoffreyBooth left a comment

Uh oh!

MylesBorins commented Apr 2, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Apr 3, 2020

Uh oh!

MylesBorins commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

MylesBorins commented Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Uh oh!

Conversation

MylesBorins commented Apr 2, 2020

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

MylesBorins commented Apr 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Apr 2, 2020

Uh oh!

GeoffreyBooth left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Apr 2, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Apr 3, 2020

Uh oh!

MylesBorins commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

nodejs-github-bot commented Apr 3, 2020

Uh oh!

MylesBorins commented Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

MylesBorins commented Apr 2, 2020 •

edited

Loading