Skip to content

test: add tmpdir.fileURL()#49040

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
LiviaMedeiros:test-ft-tmpdir-url
Aug 10, 2023
Merged

test: add tmpdir.fileURL()#49040
nodejs-github-bot merged 1 commit intonodejs:mainfrom
LiviaMedeiros:test-ft-tmpdir-url

Conversation

@LiviaMedeiros
Copy link
Member

@LiviaMedeiros LiviaMedeiros commented Aug 6, 2023 •
edited
Loading

Almost every time tmpdir.path is used in tests, we have to import path to use it.
Whenever we need URL of something in tmpdir, we also have to import url.pathToFileURL.
Adding tmpdir.url would reduce

import { join } from 'node:path';
import { pathToFileURL } from 'node:url';
const testFile = pathToFileURL(join(tmpdir.path, 'subdir', 'tst-file-123'));

to

const testFile = tmpdir.resolve('subdir', 'tst-file-123');

or to native resolving

const tmpBase = tmpdir.fileURL();
const testFile = new URL('subdir/tst-file-123', tmpBase);

Additionally, maybe we could add path-oriented tmpdir.resolve(...paths) to replace path.join(tmpdir.path, ...paths) in tests?

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 6, 2023
@tniessen
Copy link
Member

tniessen commented Aug 6, 2023

Why is the URL not a URL?

@LiviaMedeiros
Copy link
Member Author

LiviaMedeiros commented Aug 6, 2023

Why is the URL not a URL?

For consistency with import.meta.url and general guideline. No strong opinion here.

@tniessen
Copy link
Member

tniessen commented Aug 6, 2023

I see. For anyone else wondering the same thing, it sounds like the main issue is that URL is meant to be mutable, which is undesirable for values that are not meant to be modified.

@aduh95
Copy link
Contributor

aduh95 commented Aug 8, 2023

We could have tmpdir.fileURL() which would return a new URL instance, and would accept a relative URL as optional parameter, that would be consistent with fixtures.mjs. wdyt?

@joyeecheung
Copy link
Member

joyeecheung commented Aug 8, 2023

Considering we also already have fixtures.fileURL() and fixtures.path() I think tmpdir.fileURL() and tmpdir.resolve() (because tmpdir.path is already taken) would make a lot of sense (I've always wondered why we don't have tmpdir.resolve() whenever I have to do path.join(tmpdir.path))

@LiviaMedeiros LiviaMedeiros changed the title test: add tmpdir.url test: add tmpdir.fileURL() Aug 9, 2023
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 9, 2023
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 10, 2023
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 10, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/53136/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 7bbcb29 into nodejs:main Aug 10, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Aug 10, 2023

Landed in 7bbcb29

@github-actions github-actions bot mentioned this pull request Aug 11, 2023
Open
29 tasks
@LiviaMedeiros LiviaMedeiros mentioned this pull request Aug 13, 2023
Merged
martenrichter pushed a commit to martenrichter/node that referenced this pull request Aug 13, 2023
@LiviaMedeiros @martenrichter
test: add tmpdir.fileURL()
62deae3 
PR-URL: nodejs#49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@LiviaMedeiros @Ceres6
test: add tmpdir.fileURL()
a717c88 
PR-URL: nodejs#49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@LiviaMedeiros @Ceres6
test: add tmpdir.fileURL()
f9cb59d 
PR-URL: nodejs#49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.fileURL()
946de9c 
PR-URL: #49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.fileURL()
59767f3 
PR-URL: nodejs#49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
rluvaton pushed a commit to rluvaton/node that referenced this pull request Aug 15, 2023
@LiviaMedeiros @rluvaton
test: add tmpdir.fileURL()
6e37ede 
PR-URL: nodejs#49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@LiviaMedeiros @RafaelGSS
test: add tmpdir.fileURL()
669ac03 
PR-URL: #49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Aug 21, 2023
@LiviaMedeiros
test,benchmark: use tmpdir.fileURL()
eeddbfa 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <[email protected]>
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@LiviaMedeiros @UlisesGascon
test,benchmark: use tmpdir.fileURL()
fac56db 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@LiviaMedeiros @targos
test: add tmpdir.fileURL()
abedad7 
PR-URL: nodejs#49040
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@targos targos mentioned this pull request Nov 11, 2023
Closed
targos pushed a commit that referenced this pull request Nov 23, 2023
@LiviaMedeiros @targos
test: add tmpdir.fileURL()
65058d9 
PR-URL: #49040
Backport-PR-URL: #50669
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
targos pushed a commit that referenced this pull request Nov 27, 2023
@LiviaMedeiros @targos
test,benchmark: use tmpdir.fileURL()
b011a49 
PR-URL: #49138
Refs: #49040
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: add tmpdir.fileURL()
1d47b07 
PR-URL: nodejs/node#49040
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test,benchmark: use tmpdir.fileURL()
bdcdb85 
PR-URL: nodejs/node#49138
Refs: nodejs/node#49040
Reviewed-By: Luigi Pinca <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: add tmpdir.fileURL()
82316a5 
PR-URL: nodejs/node#49040
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test,benchmark: use tmpdir.fileURL()
1eea878 
PR-URL: nodejs/node#49138
Refs: nodejs/node#49040
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LiviaMedeiros @tniessen @aduh95 @joyeecheung @nodejs-github-bot @targos